Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken images in Markdown import #3649

Closed
SnowDrifterr opened this issue Feb 26, 2023 · 5 comments
Closed

Broken images in Markdown import #3649

SnowDrifterr opened this issue Feb 26, 2023 · 5 comments

Comments

@SnowDrifterr
Copy link

Trilium Version

0.58.8

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows 11 22623.1250

Description

When I import a .zip containing markdown files and linked images, the links to said images display as a broken/empty link

image

Error logs

No response

@eliandoran eliandoran changed the title (Bug report) Broken images in Markdown import Feb 26, 2023
@zadam
Copy link
Owner

zadam commented Feb 27, 2023

Hello, can you provide a sample of the Markdown file which causes this? Either here or to zadam.apps@gmail.com.

Thanks.

@hxchtiewei
Copy link

Hello, can you provide a sample of the Markdown file which causes this? Either here or to zadam.apps@gmail.com.

Thanks.

import-test.zip

@SnowDrifterr
Copy link
Author

Original page:

image
Draw-Test.zip

@Nriver
Copy link
Contributor

Nriver commented Mar 2, 2023

import

You can try to import your markdowns with my trilium-py. It will handle the images for you.

@zadam zadam closed this as completed in 540d19c Mar 2, 2023
@zadam
Copy link
Owner

zadam commented Mar 2, 2023

Hello, thank you for the samples. URL rewriting for the images was broken if there was no meta-file. This is now fixed.

There will still be some extra tokens like {width="4.375in" since those are non-standard Markdown extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants