Race condition in SQL console (save changes vs execute query)

[mechanarchy]

Trilium Version

0.59.4

What operating system are you using?

macOS

What is your setup?

Server access only

Operating System Version

macOS Monterey 12.6.3

Description

A race condition exists in the SQL console, between changes being pushed to the backend, and the request for a query to be executed.

This mostly happens when I am actively modifying the query and then quickly press Ctrl+Enter. In the screenshots below, I:

1. Enter the query SELECT '' and wait for the note to be saved
2. Quickly type asd into the single quotes, and then quickly press Ctrl+Enter
3. See that the result of the SQL query is '' and not 'asd' as expected.

Looking at the request timeline in developer tools, it is clear the race condition is present:

Error logs

No response

[mechanarchy]

A quick look at the code suggests the Entrypoints:runActiveNoteCommand function is where a change should be made:

trilium/src/public/app/components/entrypoints.js

Lines 170 to 173 in 6f16b4c

	} else if (note.mime.endsWith("env=backend")) {
	await server.post(`script/run/${note.noteId}`);
	} else if (note.mime === 'text/x-sqlite;schema=trilium') {
	const resp = await server.post(`sql/execute/${note.noteId}`);

By forcing another save using a command like this:

trilium/src/public/app/widgets/note_detail.js

Line 86 in 6f16b4c

await server.put(`notes/${noteId}/data`, data, this.componentId);

But I'm not sure about the cleanest way of doing it.

[zadam]

fixed