create skipper ingress daemon set #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjacobs
reviewed
Dec 13, 2016
| cpu: 25m | ||
| memory: 25Mi | ||
| - name: kubectl | ||
| image: registry.opensource.zalan.do/teapot/hyperkube:v1.5.0-beta.2_custom.0 |
There was a problem hiding this comment.
we should use the same hyperkube version as everywhere else
mikkeloscar
reviewed
Dec 13, 2016
| cpu: 25m | ||
| memory: 25Mi | ||
| - name: kubectl | ||
| image: registry.opensource.zalan.do/teapot/hyperkube:v1.5.0-beta.2_custom.0 |
There was a problem hiding this comment.
It would make sense to use the same hyperkube image here as we do in all other places.
This is currently: registry.opensource.zalan.do/teapot/hyperkube:v1.4.7_zalando.0
hjacobs
reviewed
Dec 13, 2016
| ports: | ||
| - containerPort: 8001 | ||
| hostNetwork: true | ||
| hostPID: true |
There was a problem hiding this comment.
removed, thx, not needed at all
hjacobs
reviewed
Dec 13, 2016
| - proxy | ||
| ports: | ||
| - containerPort: 8001 | ||
| hostNetwork: true |
There was a problem hiding this comment.
hostNetwork means that the kubectl container port 8001 is opened on the host's "localhost"
There was a problem hiding this comment.
removed, thx, not needed atm
|
👍 |
1 similar comment
|
👍 |
szuecs
added a commit
that referenced
this pull request
Sep 10, 2018
* add dualstack (IPv6) support (#209) * added a flag to blacklist certificate ARNs, that will not be considered * Allow control of the SSL policy applied to https listeners via flag (#20 @jhohertz) * Detach non-existing target groups from ASGs (#198) * Reduce cert lookups within a single update (#193) * Cleanup controller initialization and termination (#194) Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ingress skipper router to the cluster