Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Filters for caching #108

Open
danpersa opened this issue Oct 18, 2018 · 0 comments
Open

[RFC] Filters for caching #108

danpersa opened this issue Oct 18, 2018 · 0 comments
Assignees
Labels

Comments

@danpersa
Copy link
Collaborator

There are many parameters caching filters can take. Based on these, they can look different. The goal of this issue is to identify the best way these caching filters can look like. Here are different options:

Putting they type of cache in the filter name and create many filters:

localFileCache(directory)
inMemoryCache(namespace)
s3Cache(url, username, password)

Giving the caching strategy as a parameter:

cache("localFileSystem", directory)
cache("memory", namespace)
cache("S3", url, username, password)

There are other questions as well, like should we give the caching parameters to the filter, or should they be configured once, when skrop starts? In case there is a global config, the filters could look like:

localFileCache()
inMemoryCache()
s3Cache()

Note: This approach brings less flexibility, as parameters can't be configured for each route

There might be other options as well. Let's discuss about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants