This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
Added Authorization implementation according latest plugin #1014
+156
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcillo
reviewed
Jan 31, 2019
rcillo
reviewed
Jan 31, 2019
| @@ -48,6 +48,7 @@ public void setCreatedAt(final DateTime createdAt) { | |||
| this.createdAt = createdAt; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@Kunal-Jha please address this comment as well
rcillo
reviewed
Jan 31, 2019
v-stepanov
reviewed
Feb 1, 2019
v-stepanov
reviewed
Feb 1, 2019
src/main/java/org/zalando/nakadi/service/AuthorizationValidator.java
Outdated
Show resolved
Hide resolved
v-stepanov
reviewed
Feb 1, 2019
Kunal-Jha
changed the title
v-stepanov
reviewed
Feb 4, 2019
v-stepanov
reviewed
Feb 4, 2019
| @@ -100,7 +100,7 @@ public void validateSubscriptionChange(final Subscription old, final Subscriptio | |||
| if (!Objects.equals(newValue.getInitialCursors(), old.getInitialCursors())) { | |||
| throw new SubscriptionUpdateConflictException("Not allowed to change initial cursors"); | |||
| } | |||
| authorizationValidator.validateAuthorization(old.getAuthorization(), newValue.getAuthorization()); | |||
| authorizationValidator.validateAuthorization(old.asResource(), newValue.asBaseResource()); | |||
There was a problem hiding this comment.
As you call newValue.asBaseResource() - it will create a resource without a name. I think it's fine to create a resource without a name for a subscription that is not created yet, but in this user modifies subscription that already exists so I think the id should be used as a resource name.
There was a problem hiding this comment.
added in the commit
rcillo
reviewed
Feb 6, 2019
src/main/java/org/zalando/nakadi/service/AuthorizationValidator.java
Outdated
Show resolved
Hide resolved
|
@Kunal-Jha please, check the comments once more. I think we have only some minor things and it's missing a merge from master. |
|
@rcillo Apologies!! somehow I missed that :( . . Added the new commits. |
|
👍 |
rcillo
approved these changes
Feb 12, 2019
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Description
Made Changes to Nakadi according to the new plugin api interfaces. All the
allAuthorizationAttributeValidare changed except for admin authorization where permissions are used.Review