Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(precompile): add trivial encrypt #48

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Conversation

tremblaythibaultl
Copy link
Contributor

Add an overload for asEuintX that takes as input a uint256 value and returns a handle to the trivial encryption of said value.
Contributes to zama-ai/go-ethereum#116 and #46.
Meant to be used with zama-ai/go-ethereum/pull/117.

Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

As a side note, maybe we need to somehow ensure a prettier is run, because we don't have linters in the Python comment. I think there is a call to npm prettier in package.json.

As another side note, I am wondering if we can get away without npm and JS in the Solidity library, but I think @immortal-tofu knows more.

@tremblaythibaultl tremblaythibaultl merged commit f30df9b into main Jun 21, 2023
@tremblaythibaultl tremblaythibaultl deleted the louis/trivial-encrypt branch June 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants