Optimize gas estimation running time #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartdart26
force-pushed
the
petar/optimize-gas-estimation
branch
from
45482b3
to
b560924
Compare
Optimize gas estimation running time with two approaches: 1. Don't call any storage methods on SSTORE during gas estimation. Instead, return early if we are in gas estimation (Commit = false). For that to work, make sure that on SLOAD, we first lookup the ciphertext hash in memory and, if found, use it without going to storage. That improves performance by not doing heavy work of splitting a ciphertext to 32 byte slots and persisting it to a memory-backed store for no reason. 2. When importing a random ciphertext during gas estimation, do not use public key encryption. Instead, just genearate an unique hash for the random ciphertext by utilizing a counter that is part of the EVM itself. That improves performance by not doing public key encryption and serialization just to compute a ciphertext hash (handle).
Rationale is that SSTORE charges less for zeroes. Using hash(counter), we make gas estimation close to random ciphertext bytes.
dartdart26
force-pushed
the
petar/optimize-gas-estimation
branch
from
b560924
to
ac05771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize gas estimation running time with two approaches: