Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalar ops, bitshift, min/max #130

Merged
merged 13 commits into from
Jun 27, 2023
Merged

Conversation

tremblaythibaultl
Copy link
Contributor

Add scalar ops for add, sub, mul, shl, shr, eq, ne, ge, gt, le, lt, min, max;
Add ops for shl, shr, ne, min, max, neg, not.
Change lte to le to preserve consistency

@tremblaythibaultl tremblaythibaultl self-assigned this Jun 26, 2023
@tremblaythibaultl
Copy link
Contributor Author

tremblaythibaultl commented Jun 26, 2023

Contributes to #116 and closes #126.

@tremblaythibaultl tremblaythibaultl marked this pull request as ready for review June 26, 2023 12:20
Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

core/vm/tfhe_test.go Outdated Show resolved Hide resolved
core/vm/tfhe_test.go Outdated Show resolved Hide resolved
@tremblaythibaultl tremblaythibaultl merged commit c78c376 into 1.10.19-zama Jun 27, 2023
1 check passed
@tremblaythibaultl tremblaythibaultl deleted the louis/scalar_ops branch July 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants