-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant and low-res artwork #50
Comments
the artwork is included in every plugin so that they can be completely self-contained. generating the artwork before build is possible, but the user would need some extra things installed to be able to build the plugins (python3, numpy, pil). in the future I hope we can do scalable plugin UIs. |
I just cannot see the use case or follow your argument: 1) there are no individual source packages for single plugins so why bothering with self-containment, 2) the plugins in the Git repo use the same shared dpf module, so the same could be true for assets and 3) the |
I meant that the binary they produce is fully self-contained. |
But I meant the duplication in the repository. I am not arguing against bundling the binaries with the data, that's a neat idea. |
@matze firstly, thank you for investing some time in this. When I created the image assets, I did not take into account that I would be reusing a lot of the assets. This certainly could be improved. I agree that the images are causing the clone time to be increased unnecessarily. I think it might be worth using some kind of |
I don't think its a really good idea to increase the bitmap size, because it still needs to work on small screened laptops where I do my recording. Others may find this also to be the case, but I can't accommodate for everyone's 4K monitors unfortunately. It would be good to one day have scalable GUIs. |
@zamaudio is related code resides only in https://github.com/zamaudio/zam-plugins/blob/master/widgets/ZamWidgets.hpp ? i am thinking about taking a try on it as part of c++ learning or you want to switch from bitmaps to having sorta cairo-based toolkit? |
@actionless : see DPF. It is a submodule that handles the UI toolkit. |
nanosvg might be an option for scalable UIs. |
Has there been any progress with support for HiDPI scaling? I use HiDPI for everything these days and generally leave behind all apps and tools for alternatives that scale ip for my screen. It would be nice to be able to use these plugins. HiDPI is much more prevalent now at the end of 2022 than things were back in 2017 when the last comment was posted. 🙂 |
UIs will automatically scale up to the correct size, but will look blurry due to artwork being bitmap based. |
should i set some env var or how it's getting desired dpi? i'm running bare window manager, so mb i am missing smth |
it gets them from X11 WM hints, but you can use |
I am in the midst of revamping the look of some of my favorite zam plugins to my liking (nothing against the original artwork but it suffered from low contrast and a cramped feeling), see for example here. Now I noticed some issues, when I saw how the artwork is actually included in the plugins:
So my question is, are there plans to
If you want, I could help you out with one or more of these points.
The text was updated successfully, but these errors were encountered: