-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic on multi-source apps v1.8.0 #297
Comments
Looks like there are some core chunks of the app that are not aware of multiple sources. Might not be too difficult to take into account. 🤞 |
For some reason I remember this was implemented, at least partially, but that doesn't seem to be true. OK, I built on the work that @sl1pm4t did and got a working branch. I don't have any multi source applications to test on yet, but if you want a sneak preview, you can use the image at ghcr.io/zapier/kubechecks:0.0.0-pr298, and report back if it works as intended. Thanks for the bug report! |
i'll give it a shot |
I tried that build out in my test instance with a new multi-source app - no crash, but i'm seeing permissions errors ( even with a rollback to 1.8.0 ), so i think i can tentatively say its working. but i want to figure out this permission issue before i'd say |
Permission issue fixed given that this is multi-source the helm chart itself is pulling from a remote repo (generally, we've pull them into our monorepo and haven't had an issue), it looks like Kubechecks isn't able to pull this from this remote helm repo 5:19PM INF cloning repo branchName=1.4.3 event_id=50 repo=repo-name-redacted
5:19PM INF cloning git repo branch=1.4.3 clone-url=https://audrey-mux@grafana.github.io/helm-charts temp-dir=/tmp/kubechecks-repo-489429976
5:19PM DBG building command args=["clone","https://audrey-mux@grafana.github.io/helm-charts","/tmp/kubechecks-repo-489429976","--branch","1.4.3"]
5:19PM DBG getting cluster clusterName= clusterServer=https://kubernetes.default.svc
5:19PM DBG generating diff for application... name=cluster-bootstrap-apps
5:19PM DBG for appname cluster-bootstrap-apps, server dest says: https://kubernetes.default.svc and name dest says:
5:19PM ERR unable to clone repository, Cloning into '/tmp/kubechecks-repo-489429976'...
fatal: repository 'https://grafana.github.io/helm-charts/' not found
error="exit status 128"
5:19PM ERR Unable to clone repository error="failed to clone repo: failed to clone repository: exit status 128" app_name=<redacted>-beyla app_path= event_id=50 repo=repo-name-redacted workerID=15 and the appset sources:
- repoURL: https://grafana.github.io/helm-charts
chart: beyla
targetRevision: 1.4.3
helm:
releaseName: beyla
valueFiles:
- $values/monitoring/grafana-cloud/beyla/values.yaml
- repoURL: https://github.com/org/repo.git
targetRevision: master
ref: values it looks like it think this is a git repo vs a helm repo |
I also tried moving the chart to a git repo instead with a different outcome sources:
- repoURL: https://github.com/org/helmchart.git
path: tools/helm/beyla
targetRevision: main
helm:
releaseName: beyla
valueFiles:
- $values/monitoring/grafana-cloud/beyla/values.yaml
- repoURL: https://github.com/org/valuesfile.git
targetRevision: master
ref: values I had to drop the values file in the helmchart repo otherwise kubechecks couldn't find it - from what it looks like in the logs, the first repo (helmchart) is checked out and diffed, and then the second repo (valuesfile) is checked out but fails to get the helm chart since it doesn't exist at that path. |
Ah, yup, that makes sense. I took a quick stab at implementing it, but found that I didn't really understand what I was working in. I'm taking a step or two back so I can learn exactly what multisource apps are and all the different ways you can use and abuse them. |
OK, made a new strong attempt. want to give the new image a shot? It's still |
Awesome, i'll give it a go. |
awww yeah, looks like that works. thanks for the heads up about the repo-server connection, had to make adjustments to the default argocd network policies but knowing that connection was required saved me a lot of time. |
Awesome! Yeah, gonna be fun to try and document this one. I think it leads to more consistent behavior, but it's also tightly couples the app to an internal service. Not sure how I feel about this, but the alternative is forking and copying code, which isn't pretty either. |
Ran across a panic when trying to process a multi-source app. We just started using those and this is the second one so far, the first one just produced a warning w/o the panic
The text was updated successfully, but these errors were encountered: