-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation tab might use outdated jobs #7799
Comments
How to proceed with this? Does it mean to uninstall the Report Generation addon? |
Yes. |
Hey! Is something like this good? - Every time someone runs a plan, it would first check if all the jobs mentioned in that plan have their corresponding addOns installed or not. And if not installed, mark that job run as fail and give a message like "spider addOn not installed" in the output window of the automation tab Also, is this a problem just with the GUI? or with other methods too like the CLI? (Actually I have just checked with GUI as of now, so that's why asking). |
That does not address the problem since the GUI still shows jobs that might no longer be present or are outdated (i.e. step 4). IMO the tab should try (re)load the plan after jobs are added/removed (if present in the plan), which would recreate the GUi or fail with an error if the jobs are unrecognised. Yes, this is a GUI specific problem (label added to be clearer). |
hello I want to work on this issue |
@aryangupta701, ahh sorry but have you actually started working on it? I was actually brainstorming on this issue from past few days and I think I have some progress too. I guess I should have asked for assignment beforehand, but I forgot somehow :( My bad :( |
Not yet. You can take over this issue. :) |
@aryangupta701 Thanks :) |
@thc202 @kingthorin, little help needed as I had few doubts -
I do need to listen for events right? in order to implement this. Because only then it would show dynamic changes to the GUI tab. Please correct me if I am wrong. Also, sorry for actually delaying it. I wanted to take the least amount of help for this issue and do it all by myself. But I am little stuck here now. I think I have went through all the files of Automation. |
It looks like there's an event you could use: https://github.com/zaproxy/zaproxy/blob/main/zap/src/main/java/org/zaproxy/zap/extension/autoupdate/UninstallationProgressDialogue.java#L391 |
ohh okay, Thanks! |
That's internal, you should use an
Although, the jobs are added/removed through the |
Thanks @thc202 |
@thc202 Thanks for this! |
Describe the bug
The Automation tab dos not refresh the plan when jobs are added/removed which leads to issues.
Steps to reproduce the behavior
report
job.report
job which leads to other errors, e.g.:Expected behavior
The Automation tab should properly handle dynamic changes of jobs (update/removal).
Software versions
Automation Framework v0.27.0
The text was updated successfully, but these errors were encountered: