Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6, Linting and Code Style in Vue #469

Open
nothingismagick opened this issue Apr 23, 2019 · 0 comments
Open

ES6, Linting and Code Style in Vue #469

nothingismagick opened this issue Apr 23, 2019 · 0 comments

Comments

@nothingismagick
Copy link
Contributor

So, I've started adding the beforeDestroy hooks per #468 , but have noticed that you aren't using any enforced linting or canonical JS style. This means that there are a mixture of tabs and five spaces etc. It's hard for me to know what is canonical.

And after seeing the really awesome PR I had to #459 (review) it. And in that context I think its probably better for me NOT to work on the code at the moment and to wait for that PR to be polished and land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant