Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License Header #1

Open
kingthorin opened this issue Sep 5, 2017 · 5 comments · May be fixed by #843
Open

License Header #1

kingthorin opened this issue Sep 5, 2017 · 5 comments · May be fixed by #843

Comments

@kingthorin
Copy link
Member

I assume our standard license blurb should be added to all java files?
https://github.com/psiinon/zap-hud/blob/master/src/org/zaproxy/zap/extension/hud/HudAPI.java

What about all the JS files?
@psiinon
Copy link
Member

psiinon commented Sep 5, 2017

Definitely the java ones, probably the JS ones too?

@kingthorin
Copy link
Member Author

In general it'll be local delivery so we don't really need to worry about size, so yes I think including it in the JS files is a good move.

@thc202
Copy link
Member

thc202 commented Sep 5, 2017

+1

@thc202
Copy link
Member

thc202 commented Nov 23, 2018

The license header is already being enforced in Java files (#227).

@psiinon
Copy link
Member

psiinon commented Nov 26, 2018

Can we do the same with JS files?

psiinon referenced this issue in psiinon/zap-hud Dec 4, 2018
@psiinon
Merge pull request #1 from dscrobonia/reveal
544f7a0 
added reveal to the HUD
@jveldhuijzen jveldhuijzen linked a pull request Nov 24, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Lint javascript for license header and add licence to js files jveldhuijzen/zap-hud
3 participants
@psiinon @thc202 @kingthorin