Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio nodes new problems #33

Open
artofmus opened this issue May 2, 2015 · 6 comments
Open

Audio nodes new problems #33

artofmus opened this issue May 2, 2015 · 6 comments

Comments

@artofmus
Copy link

artofmus commented May 2, 2015

@geloescht, @zauner I must report) Convolver and Waveshaper nodes not work in mozila when development tools is on, when development tools is off this nodes work but irrational in spread mode (when i increases and decreases slice number of spred i get unexpected results (in chrome work same)). More would like to draw attention to the fact that we need a node on the similarity Add(Value Spectral) to avoid wasting CPU. And delay feedback, we have already talked about)

@geloescht
Copy link
Contributor

Concerning Convolver and Waveshaper, this is a bug in the Firefox development tools which I have worked around for all other nodes but not those too. I will fix that in a short while.
I guess Waveshaper could be irrational due to its Curve input being a spread and bin size. I must admit I've got some problems wrapping my head around bin size.
Add (HTML5 Audio Spectral) is planned and trivial to implement.
@artofmus: Please feel free to experiment with delays_output = true in Delay (HTML5 Audio). It might just work or require extra implementation - I have not investigated yet.

@geloescht
Copy link
Contributor

OK, my newest revision of the audio branch at geloescht/vvvv.js@7cbc7e0 should fix the debugging issue in Firefox and also adds Add (HTML5 Audio Spectral) as well as a nice ADSR (Animation).
Any help on how to implement the curve input of WaveShaper according to http://vvvv.org/documentation/binsize would be welcome! The key here is in the implementation of WaveShaper.getAudioSliceCount().

@artofmus
Copy link
Author

artofmus commented May 2, 2015

@geloescht thanks, super! But convolver still strange.. problem probably with FileBuffer, when i change names of the buffers in spreaded string input - buffers not change (i can specify the names of the buffers only once for a single node). Generally it is not a big Problem, just for cleanliness)

@artofmus
Copy link
Author

artofmus commented May 8, 2015

@geloescht the same problem exists in OscillatorNode, type input pin work only for first slice of spread.

@geloescht
Copy link
Contributor

@artofmus: Can't reproduce, both seem to work fine to me (tested only on Chrome due to the ongoing issues Firefox has with certain wav files). If you are still experiencing problems please upload a zip file with a minimal example and post it here.

@artofmus
Copy link
Author

artofmus commented May 9, 2015

@geloescht I'm sorry,.. I have something confused, checked the wrong code. everything works!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants