Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addition of snakemake compatible format and linting #104

Merged
merged 6 commits into from
Dec 4, 2022

Conversation

mkatsanto
Copy link
Collaborator

Description

For the workflow to be compatible with snakemake workflows catalogue, there are specific guidelines for formating (using snakefmt) and linting (snakemake --lint)

Fixes #12

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

dominikburri
dominikburri previously approved these changes Dec 2, 2022
Copy link
Contributor

@dominikburri dominikburri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mkatsanto,
Thanks for the updates!
I installed snakefmt (thanks for the addition in the dev environment) and ran the new tests in tests/test_format. Both, snakefmt and linting exited with code 0.

LGTM :)

@noepozzan
Copy link
Collaborator

Hi @mkatsanto, Thanks for the updates! I installed snakefmt (thanks for the addition in the dev environment) and ran the new tests in tests/test_format. Both, snakefmt and linting exited with code 0.

LGTM :)

worked for me, too!

@mkatsanto
Copy link
Collaborator Author

add a configfile specification because linting in snakemake workflows catalogue does not take config as an input.

@mkatsanto mkatsanto requested a review from fgypas December 4, 2022 20:59
@mkatsanto mkatsanto merged commit efa0375 into dev Dec 4, 2022
@mkatsanto mkatsanto deleted the snakeformat branch December 4, 2022 21:01
@mkatsanto mkatsanto added the enhancement New feature or request label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snakefmt and lint checks
4 participants