Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sra): improve layout extraction from NCBI db #168

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Conversation

mkatsanto
Copy link
Collaborator

Description

The issue is described in #166 . The solution applied is that only for samples that either the PAIRED or SINGLE library layouts, the samples will pass through the workflow, otherwise the samples are silently dropped. As for the recovery of the layout in the get_layout rule, there is an improvement in the syntax as there was no need for the csv2xml that was causing the issue in the first place, as there is already an option of -mode xml in the efetch command that then allows direct extraction of the layout feature.

Fixes #166

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Conventional Commits guidelines

Changes to workflow inputs (sample table and/or configs)

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • more fields/properties are required
    • existing ones are dropped entirely
  • minor (add feat: in the beginning of the PR title)
    • optional fields/properties are added
    • required ones are made optional

Changes to workflow outputs

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • changes lead to removal/change of existing outputs (format or location)
  • minor (add feat: in the beginning of the PR title)
    • additional outputs are generated
    • content (but not format or location) of existing outputs changes

Everything else: patch
(add any other conventional commit in the beginning of the PR title)

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes

Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks and sounds good to me, but I find it a bit hard to review it. How extensively have you tested it on real data?

@mkatsanto
Copy link
Collaborator Author

I tried with some non-existent names and then with the examples failing in issue #166. I could try a few more random ones.

@uniqueg uniqueg changed the title fix: (SRA download) get layout fix(sra): improve layout extraction from NCBI db Feb 5, 2024
@mkatsanto mkatsanto merged commit 4b5a1cc into dev Feb 5, 2024
11 checks passed
@mkatsanto mkatsanto deleted the issue_166_get_layout branch February 5, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(SRA download): rule get layout often fails
2 participants