-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sra): improve layout extraction from NCBI db #168
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uniqueg
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks and sounds good to me, but I find it a bit hard to review it. How extensively have you tested it on real data?
I tried with some non-existent names and then with the examples failing in issue #166. I could try a few more random ones. |
uniqueg
changed the title
fix: (SRA download) get layout
fix(sra): improve layout extraction from NCBI db
Feb 5, 2024
uniqueg
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is described in #166 . The solution applied is that only for samples that either the PAIRED or SINGLE library layouts, the samples will pass through the workflow, otherwise the samples are silently dropped. As for the recovery of the layout in the get_layout rule, there is an improvement in the syntax as there was no need for the csv2xml that was causing the issue in the first place, as there is already an option of -mode xml in the efetch command that then allows direct extraction of the layout feature.
Fixes #166
Type of change
Please delete options that are not relevant.
Conventional Commits guidelines
https://www.conventionalcommits.org/en/v1.0.0/
Changes to workflow inputs (sample table and/or configs)
Changes to workflow outputs
Everything else: patch
(add any other conventional commit in the beginning of the PR title)
Checklist: