Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: turn MultiQC logo config params optional #74

Merged
merged 1 commit into from
Oct 28, 2022
Merged

chore: turn MultiQC logo config params optional #74

merged 1 commit into from
Oct 28, 2022

Conversation

AngryMaciek
Copy link
Member

@AngryMaciek AngryMaciek commented Jul 3, 2022 •
edited
Loading

Description

Config params for MultiQC logo (img/url) are optional now: empty string or param absence result in no logo in the final report.

Fixes #72

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes

@AngryMaciek AngryMaciek added enhancement New feature or request good first issue Good for newcomers labels Jul 3, 2022
@AngryMaciek AngryMaciek self-assigned this Jul 3, 2022
@AngryMaciek AngryMaciek changed the title WIP chore: turn MultiQC logo config params optional Jul 3, 2022
@AngryMaciek AngryMaciek requested a review from uniqueg July 3, 2022 00:32
uniqueg
uniqueg approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks a lot! Looks good to me

@uniqueg uniqueg requested a review from mkatsanto July 4, 2022 12:15
@uniqueg
Copy link
Member

uniqueg commented Jul 4, 2022

@mkatsanto: Maria, please merge if looks good to you as well.

@ninsch3000 ninsch3000 merged commit 855776d into dev Oct 28, 2022
@ninsch3000 ninsch3000 deleted the multiqc-logo-url branch October 28, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueg uniqueg uniqueg approved these changes

@mkatsanto mkatsanto Awaiting requested review from mkatsanto

Assignees

@AngryMaciek AngryMaciek

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Du not require logo & URL for MultiQC report
3 participants
@AngryMaciek @uniqueg @ninsch3000