Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_helm_installations doesn't support --kube-context #82

Open
aarcro opened this issue May 19, 2023 · 0 comments
Open

get_helm_installations doesn't support --kube-context #82

aarcro opened this issue May 19, 2023 · 0 comments

Comments

@aarcro
Copy link

aarcro commented May 19, 2023

def get_helm_installations(namespace: Optional[str] = None):

Without taking an options dict, we can't pass kube-context to tell helm which cluster to get the installations from. (Well we can, because the string handling isn't secure, we can just use f"{namespace} --kube-context {context}" for the namespace name, but that seems abusive).

def is_installed(self):

is_installed as a property also has no way to pass the context. But that seems like a bigger lift to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant