Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging #4145 broke the compilation on macOS #4164

Closed
rex4539 opened this issue Oct 22, 2019 · 1 comment · Fixed by #4166
Closed

Merging #4145 broke the compilation on macOS #4164

rex4539 opened this issue Oct 22, 2019 · 1 comment · Fixed by #4166
Milestone

Comments

@rex4539
Copy link
Contributor

rex4539 commented Oct 22, 2019

mempool_limit.cpp:154:20: error: no matching function for call to 'max'
    int64_t cost = std::max(memUsage, MIN_TX_COST);
                   ^~~~~~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2529:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long' vs. 'unsigned long long')
max(const _Tp& __a, const _Tp& __b)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2539:1: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'unsigned long'
max(initializer_list<_Tp> __t, _Compare __comp)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2521:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided
max(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2547:1: note: candidate function template not viable: requires single argument '__t', but 2 arguments were provided
max(initializer_list<_Tp> __t)
^
1 error generated.
make[2]: *** [libbitcoin_server_a-mempool_limit.o] Error 1
@Eirik0
Copy link
Contributor

Eirik0 commented Oct 22, 2019

Thanks for reporting this. We will look in to it shortly.

@Eirik0 Eirik0 added this to the v2.1.0 milestone Oct 22, 2019
@zkbot zkbot closed this as completed in 63c5cf3 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants