Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese input method causes conflicts with Vim key bindings #21136

Open
1 task done
mcpeng opened this issue Nov 24, 2024 · 3 comments
Open
1 task done

Chinese input method causes conflicts with Vim key bindings #21136

mcpeng opened this issue Nov 24, 2024 · 3 comments
Labels
bug [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc

Comments

@mcpeng
Copy link

mcpeng commented Nov 24, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Vim key binding snippet:

  {
    "context": "Editor && vim_mode == insert",
    "bindings": {
      "j j": "vim::NormalBefore"
    }
  }

In insert mode, using the Pinyin input method can not type words that start with j, such as "简单"(pinyin: jiandan)

Environment

  • macOS 14.6.1
  • Zed 0.162.5
  • Input method: Pinyin - Simplified

If applicable, add mockups / screenshots to help explain present your vision of the feature

pinyin.mov

If applicable, attach your Zed.log file to this issue.

Zed.log

@mcpeng mcpeng added admin read bug [core label] labels Nov 24, 2024
@notpeter notpeter added internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc and removed triage labels Nov 25, 2024
@flczcy
Copy link

flczcy commented Dec 1, 2024

when vim_mode != insert then "Dispatching shortcuts before IME"
when vim_mode == insert do not "Dispatching shortcuts before IME"

@ConradIrwin
Copy link
Member

Ugh, sorry about this.

I think the right fix is to send no-longer pending keystrokes to the system IME instead of just to our input handler.

@yintzuyuan
Copy link

Not only Pinyin input method, but also the Zhuyin input method for Traditional Chinese have the same problem. I hope this issue can be fixed, and is there a temporary solution before the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc
Projects
None yet
Development

No branches or pull requests

5 participants