Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes with stdsimd on latest Rust Nightly version. #7644

Closed
1 task done
nshout opened this issue Feb 10, 2024 · 2 comments · Fixed by #7770
Closed
1 task done

Changes with stdsimd on latest Rust Nightly version. #7644

nshout opened this issue Feb 10, 2024 · 2 comments · Fixed by #7770
Labels
bug [core label] open source Open source community projects, contributions, etc rust Rust programming language support

Comments

@nshout
Copy link

nshout commented Feb 10, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Rustc Version: rustc 1.78.0-nightly (d44e3b95c 2024-02-09)

Description:
When attempting to compile Zed using the latest Nightly version of Rust, users encounter an E0635 error. This error specifically points to an unknown feature, namely stdsimd. Subsequent investigation reveals recent alterations within the Rust repository related to stdsimd.

Steps to Reproduce:

Install the latest Nightly version of Rust.
Clone the Zed repository.
Attempt to compile Zed using the standard build process.

Behavior:
Compilation fails with the E0635 error, indicating an unknown feature stdsimd.

Additional Information:
Upon further research, it was found that recent changes in the Rust repository may have impacted the compatibility of Zed's build process and packages that leverage stdsimd in general.

First Discovery:
Upon attempting to use GPUI for my personal project. (I was able to successfully use GPUI before updating to the latest Nightly version of Rust.)

Dependencies used with said GPUI project:
[dependencies]
gpui = { git = "https://github.com/zed-industries/zed"}

Rust commit with stdsimd changes

Command: cargo run

(Skipped successful compiled packages logs until error)

Compiling rust-embed-impl v8.2.0
error[E0635]: unknown feature stdsimd
--> /Users/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pathfinder_simd-0.5.2/src/lib.rs:12:49
|
12 | #![cfg_attr(pf_rustc_nightly, feature(simd_ffi, stdsimd))]
| ^^^^^^^

Compiling futures v0.3.30
Compiling url v2.5.0
For more information about this error, try rustc --explain E0635.
error: could not compile pathfinder_simd (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Environment

Zed: v0.121.2 (Zed Preview)
OS: macOS 14.2.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@nshout nshout added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Feb 10, 2024
@JosephTLyons JosephTLyons added rust Rust programming language support open source Open source community projects, contributions, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 13, 2024
@JosephTLyons
Copy link
Collaborator

cc @osiewicz

@osiewicz
Copy link
Contributor

Hey, thanks for filling this issue. It looks like we pull in pathfinder_simd through font-kit (for which we have our own fork); it looks like folks are already aware of the issue upstream (see: servo/font-kit#233). I'll sync up our fork tomorrow and upgrade pathfinder_simd to resolve that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] open source Open source community projects, contributions, etc rust Rust programming language support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants