Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASN.1 specification mandates ByteOrder::Big #6

Open
duffy-ocraven opened this issue Mar 7, 2022 · 1 comment
Open

ASN.1 specification mandates ByteOrder::Big #6

duffy-ocraven opened this issue Mar 7, 2022 · 1 comment

Comments

@duffy-ocraven
Copy link

Lines 82-83 in asn1.spicy

    1 -> : bytes &size=self.data.num
           &convert=$$.to_uint(spicy::ByteOrder::Network)

have the convert using ByteOrder::Network, which is probably not correct since the specification mandates ByteOrder::Big

@duffy-ocraven
Copy link
Author

https://ldap.com/ldapv3-wire-protocol-reference-asn1-ber/ shows illustrative examples in section: Note 1: Encoding BER Lengths with More Bytes than Necessary, and is a thorough and helpful treatment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant