Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken after Angular 17 + esbuild + vite implementation #66

Open
bazobehram opened this issue Aug 14, 2024 · 3 comments
Open

Broken after Angular 17 + esbuild + vite implementation #66

bazobehram opened this issue Aug 14, 2024 · 3 comments

Comments

@bazobehram
Copy link

image

"Ace is not defined"
This issue arises after implementing esbuild and Vite with the following code: This cause comes after esbuild and Vite implementation

  import 'brace/theme/github';

In a component usage:

import 'brace';
import 'brace/mode/xml';
import 'brace/mode/text';
import 'brace/theme/github';
@paulper2
Copy link

I am facing same issue any fix for this??

@mjlux
Copy link

mjlux commented Nov 22, 2024

To fix this issue you have to add brace to the scripts Array of your angular.json file.

path: angular.json > projects > [your project name] > architect > build > options > scripts

 "scripts": [
   "./node_modules/brace/index.js"
 ]

rerun ng serve after the change to angular.json and it should work as documented.

Cheers!

@guss77
Copy link

guss77 commented Jan 15, 2025

@mjlux this solution works well for me - it should be documented in the main README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants