Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm closing #399

Closed
rastasheep opened this issue Jul 25, 2016 · 8 comments
Closed

Confirm closing #399

rastasheep opened this issue Jul 25, 2016 · 8 comments
Labels
🛠 Type: Feature Request Issue or PR is a feature request/proposal for Hyper

Comments

@rastasheep
Copy link

It would be great to have some variation or both (in app or via plugins) of this iTerm features:

  • Confirm closing multiple sessions
  • Confirm "Quit iTerm2 (⌘+Q) command"

Both of those prevent accidental closing of app (and loosing work if you're not using some multiplexer).

@timothyis timothyis added the 🛠 Type: Feature Request Issue or PR is a feature request/proposal for Hyper label Jul 26, 2016
@joshwiens
Copy link

That iTerm feature is the reason why I no longer use it. While it prevents accidental closing of a session, it also blocks things like restarts.

No installed program on the planet should block a system restart command, ever.

@emmby
Copy link

emmby commented Aug 11, 2016

Hyperterm and iTerm should not block restarts, yes. However, it would be nice to have a (optional) warning before a non-restart quit/close-window. I write this having just now accidentally closed my window twice during long builds.

(This is a particular problem for people with multiple monitors, where it's easy to think one monitor has focus but in fact your other monitors does. First world problems.)

@denysdovhan
Copy link

Just now I accidentally closed hyper window and that's it. Can't wait when this feature will be added.

@joshwiens
Copy link

@emmby - I agree completely. An optional setting would be valuable and as long as it doesn't block things like system restart, on by default would be perfectly fine.

@andrewchilds
Copy link

I would widen scope a little of this request for a confirmation step to include accidental cmd+R, which I just did 🤦‍♂️

@chabou
Copy link
Contributor

chabou commented Apr 18, 2017

Is protection about hotkeys (quit app, quit pane or refresh app) enough?
Or should we warn if a user is closing app window with red button/cross?

@chabou
Copy link
Contributor

chabou commented Aug 19, 2017

@zachflower made a plugin: https://github.com/zachflower/hyper-confirm

@chabou
Copy link
Contributor

chabou commented Apr 16, 2018

More work about this will be tracked over #67

@chabou chabou closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Type: Feature Request Issue or PR is a feature request/proposal for Hyper
Projects
None yet
Development

No branches or pull requests

7 participants