Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade strip-ansi to 3.0.1 #2860

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Downgrade strip-ansi to 3.0.1 #2860

merged 1 commit into from
Aug 28, 2017

Conversation

jwillem
Copy link
Contributor

@jwillem jwillem commented Aug 28, 2017

@jwillem
Copy link
Contributor Author

jwillem commented Aug 28, 2017

solves #2747 at least for now.

@jwillem jwillem mentioned this pull request Aug 28, 2017
Closed
timneutkens
timneutkens approved these changes Aug 28, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We talked about it in the issue. Seems alright to merge this for now.

@timneutkens timneutkens merged commit 9cce984 into vercel:master Aug 28, 2017
@jwillem
Copy link
Contributor Author

jwillem commented Aug 28, 2017

thx :)

@jwillem
Copy link
Contributor Author

jwillem commented Aug 28, 2017 •
edited
Loading

As the next step follows a version bump, right?. How long would it take to release this fix?

@timneutkens
Copy link
Member

@arunoda has to do a release 👌

@oliviertassinari
Copy link
Contributor

@jwillem Happy to see this fix :).

@haydn haydn mentioned this pull request Nov 2, 2017
Closed
@landvibe landvibe mentioned this pull request Dec 1, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwillem @timneutkens @oliviertassinari