Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix language fallback in with-react-intl example #8894

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Fix language fallback in with-react-intl example #8894

merged 3 commits into from
Oct 16, 2019

Conversation

s-h-a-d-o-w
Copy link
Contributor

The call to accept.languages() made the fallback not work.
When called e.g. with Accept-Language: es-ES,es;q=0.9, locale would contain [ 'es-ES', 'es' ] instead of en.

(See also: https://www.npmjs.com/package/accepts#languagelanguages )

@s-h-a-d-o-w
Fix language fallback in with-react-intl example
9fe9435 
The call to `accept.languages()` made the fallback not work.
When called e.g. with `Accept-Language: es-ES,es;q=0.9`, `locale` would contain `[ 'es-ES', 'es' ]` instead of `en`.

(See also: https://www.npmjs.com/package/accepts#languagelanguages )
@ijjk
Copy link
Member

ijjk commented Sep 28, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
buildDuration 15.8s 15.8s -61ms
nodeModulesSize 48.2 MB 48.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..2ca0edb75.js 43.2 kB 43.2 kB ✓
de003c3a9d30..db75.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 210 kB 210 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.module.js 16.4 kB 16.4 kB ✓
main-HASH.module.js gzip 6.35 kB 6.35 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..c0.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Client Pages
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
index.html 3.62 kB 3.62 kB ✓
index.html gzip 946 B 946 B ✓
link.html 3.66 kB 3.66 kB ✓
link.html gzip 954 B 954 B ✓
withRouter.html 3.67 kB 3.67 kB ✓
withRouter.html gzip 941 B 941 B ✓
Overall change 10.9 kB 10.9 kB ✓
Serverless Mode
General
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
buildDuration 15.9s 16.3s ⚠️ +395ms
nodeModulesSize 48.2 MB 48.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.js 18.1 kB 18.1 kB ✓
main-HASH.js gzip 6.6 kB 6.6 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..2ca0edb75.js 43.2 kB 43.2 kB ✓
de003c3a9d30..db75.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 210 kB 210 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.module.js 16.4 kB 16.4 kB ✓
main-HASH.module.js gzip 6.35 kB 6.35 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..c0.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Client Pages
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_error.js 253 kB 253 kB ✓
_error.js gzip 67.9 kB 67.9 kB ✓
hooks.html 3.75 kB 3.75 kB ✓
hooks.html gzip 979 B 979 B ✓
index.js 254 kB 254 kB ✓
index.js gzip 68.2 kB 68.2 kB ✓
link.js 261 kB 261 kB ✓
link.js gzip 70.2 kB 70.2 kB ✓
routerDirect.js 255 kB 255 kB ✓
routerDirect.js gzip 68.3 kB 68.3 kB ✓
withRouter.js 255 kB 255 kB ✓
withRouter.js gzip 68.3 kB 68.3 kB ✓
Overall change 1.28 MB 1.28 MB ✓

Commit: 9fe9435

@s-h-a-d-o-w
Copy link
Contributor Author

Never mind, now languages that are actually supported don't work. Looks like this requires a slightly more elaborate solution.

@s-h-a-d-o-w
Copy link
Contributor Author

Um... sorry, my original solution was correct.

I thought I was wrong because of something else that was going on in the app where I use this example. Just double-checked it purely with this example again.

@s-h-a-d-o-w s-h-a-d-o-w reopened this Sep 29, 2019
Timer
Timer approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Timer Timer added this to the 9.1.2 milestone Oct 16, 2019
@Timer Timer added ready to land examples Issue was opened via the examples template. labels Oct 16, 2019
@ijjk
Copy link
Member

ijjk commented Oct 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
buildDuration 15.4s 16s ⚠️ +541ms
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
index.html 3.5 kB 3.5 kB ✓
index.html gzip 944 B 944 B ✓
link.html 3.55 kB 3.55 kB ✓
link.html gzip 951 B 951 B ✓
withRouter.html 3.56 kB 3.56 kB ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 10.6 kB 10.6 kB ✓
Serverless Mode
General
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
buildDuration 17.4s 16.3s -1.1s
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_error.js 255 kB 255 kB ✓
_error.js gzip 68.2 kB 68.2 kB ✓
hooks.html 3.64 kB 3.64 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js 255 kB 255 kB ✓
index.js gzip 68.5 kB 68.5 kB ✓
link.js 263 kB 263 kB ✓
link.js gzip 70.5 kB 70.5 kB ✓
routerDirect.js 256 kB 256 kB ✓
routerDirect.js gzip 68.6 kB 68.6 kB ✓
withRouter.js 256 kB 256 kB ✓
withRouter.js gzip 68.7 kB 68.7 kB ✓
Overall change 1.29 MB 1.29 MB ✓

Commit: 07d3d38

@ijjk
Copy link
Member

ijjk commented Oct 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
buildDuration 14.9s 15.3s ⚠️ +426ms
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
index.html 3.5 kB 3.5 kB ✓
index.html gzip 944 B 944 B ✓
link.html 3.55 kB 3.55 kB ✓
link.html gzip 951 B 951 B ✓
withRouter.html 3.56 kB 3.56 kB ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 10.6 kB 10.6 kB ✓
Serverless Mode
General
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
buildDuration 15.4s 15.3s -7ms
nodeModulesSize 48.5 MB 48.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..9dda6167a.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..167a.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..3a0560775.js 43.2 kB 43.2 kB ✓
de003c3a9d30..0775.js gzip 15.5 kB 15.5 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..72.module.js 45.6 kB 45.6 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary s-h-a-d-o-w/next.js patch-1 Change
_error.js 255 kB 255 kB ✓
_error.js gzip 68.2 kB 68.2 kB ✓
hooks.html 3.64 kB 3.64 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js 255 kB 255 kB ✓
index.js gzip 68.5 kB 68.5 kB ✓
link.js 263 kB 263 kB ✓
link.js gzip 70.5 kB 70.5 kB ✓
routerDirect.js 256 kB 256 kB ✓
routerDirect.js gzip 68.6 kB 68.6 kB ✓
withRouter.js 256 kB 256 kB ✓
withRouter.js gzip 68.7 kB 68.7 kB ✓
Overall change 1.29 MB 1.29 MB ✓

Commit: 9c6edfe

@Timer Timer merged commit b6be95b into vercel:canary Oct 16, 2019
This was referenced Nov 12, 2019
Merged
Open
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@s-h-a-d-o-w @ijjk @Timer