Load granular chunks with correct asset prefix #8993

zekchan · 2019-10-08T13:43:17Z

ijjk · 2019-10-08T13:49:37Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	15.1s	15.3s	⚠️ +205ms
nodeModulesSize	48.4 MB	48.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.78 kB	6.78 kB	⚠️ +2 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.51 kB	6.51 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	zekchan/next.js master	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	953 B	954 B	⚠️ +1 B
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	942 B	⚠️ +1 B
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode

General

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	15.7s	15.7s	-45ms
nodeModulesSize	48.4 MB	48.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.78 kB	6.78 kB	⚠️ +2 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.51 kB	6.51 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	zekchan/next.js master	Change
_error.js	253 kB	253 kB	✓
_error.js gzip	67.9 kB	67.9 kB	⚠️ +1 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	980 B	⚠️ +1 B
index.js	254 kB	254 kB	✓
index.js gzip	68.2 kB	68.2 kB	✓
link.js	261 kB	261 kB	✓
link.js gzip	70.3 kB	70.3 kB	⚠️ +2 B
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.3 kB	68.3 kB	⚠️ +1 B
withRouter.js	254 kB	254 kB	✓
withRouter.js gzip	68.4 kB	68.4 kB	⚠️ +1 B
Overall change	1.28 MB	1.28 MB	✓

Commit: f15b013

ijjk · 2019-10-08T14:06:07Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	14.5s	14.8s	⚠️ +259ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +28 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.78 kB	6.78 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.51 kB	6.52 kB	⚠️ +5 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	zekchan/next.js master	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	945 B	-1 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	953 B	953 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -1679,7 +1679,7 @@ function () {
                   scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
                 }
 
-                url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+                url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
                 // its own deduping mechanism.
 
                 if (!document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for main-HASH.module.js

@@ -1541,7 +1541,7 @@ class PageLoader {
         scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
       }
 
-      const url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+      const url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
       // its own deduping mechanism.
 
       if (document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for index.html

@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
+        <script src="/_next/static/runtime/main-d7b27d6e23feac796b32.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <script src="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -56,9 +56,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
+        <script src="/_next/static/runtime/main-d7b27d6e23feac796b32.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <script src="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -54,9 +54,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
+        <script src="/_next/static/runtime/main-d7b27d6e23feac796b32.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <script src="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	15.3s	15.2s	-107ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +28 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.78 kB	6.78 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.51 kB	6.52 kB	⚠️ +5 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	zekchan/next.js master	Change
_error.js	253 kB	253 kB	✓
_error.js gzip	67.9 kB	67.9 kB	-1 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	978 B	-1 B
index.js	254 kB	254 kB	✓
index.js gzip	68.2 kB	68.2 kB	-2 B
link.js	261 kB	261 kB	✓
link.js gzip	70.3 kB	70.3 kB	-1 B
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.3 kB	68.3 kB	-1 B
withRouter.js	254 kB	254 kB	✓
withRouter.js gzip	68.4 kB	68.4 kB	-1 B
Overall change	1.28 MB	1.28 MB	✓

Commit: 084adf6

fix closes vercel#8989

ijjk · 2019-10-08T14:49:32Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	16.2s	16.9s	⚠️ +704ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.78 kB	6.78 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.51 kB	6.52 kB	⚠️ +5 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	zekchan/next.js master	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	945 B	-1 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	953 B	953 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	941 B	✓
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -1679,7 +1679,7 @@ function () {
                   scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
                 }
 
-                url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+                url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
                 // its own deduping mechanism.
 
                 if (!document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for main-HASH.module.js

@@ -1541,7 +1541,7 @@ class PageLoader {
         scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
       }
 
-      const url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+      const url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
       // its own deduping mechanism.
 
       if (document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for index.html

@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
+        <script src="/_next/static/runtime/main-d7b27d6e23feac796b32.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <script src="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -56,9 +56,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
+        <script src="/_next/static/runtime/main-d7b27d6e23feac796b32.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <script src="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -54,9 +54,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-7fec32669bede780888f.js"
+        <script src="/_next/static/runtime/main-d7b27d6e23feac796b32.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-c28c44f279b4ebb99b50.module.js"
+        <script src="/_next/static/runtime/main-6e12ed49e13656a1401a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	16.6s	16.9s	⚠️ +307ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.78 kB	6.78 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.51 kB	6.52 kB	⚠️ +5 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	zekchan/next.js master	Change
_error.js	253 kB	253 kB	✓
_error.js gzip	67.9 kB	67.9 kB	-1 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	978 B	-1 B
index.js	254 kB	254 kB	✓
index.js gzip	68.2 kB	68.2 kB	-2 B
link.js	261 kB	261 kB	✓
link.js gzip	70.3 kB	70.3 kB	-1 B
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.3 kB	68.3 kB	-1 B
withRouter.js	254 kB	254 kB	✓
withRouter.js gzip	68.4 kB	68.4 kB	-1 B
Overall change	1.28 MB	1.28 MB	✓

Commit: 084c5ec

ijjk · 2019-10-09T10:21:53Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	14.4s	14.1s	-295ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.79 kB	6.79 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.52 kB	6.52 kB	⚠️ +4 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	zekchan/next.js master	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	947 B	945 B	-2 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	955 B	953 B	-2 B
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	943 B	941 B	-2 B
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -1679,7 +1679,7 @@ function () {
                   scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
                 }
 
-                url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+                url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
                 // its own deduping mechanism.
 
                 if (!document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for main-HASH.module.js

@@ -1541,7 +1541,7 @@ class PageLoader {
         scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
       }
 
-      const url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+      const url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
       // its own deduping mechanism.
 
       if (document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for index.html

@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-2132027b05a4c8c684f5.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
+        <script src="/_next/static/runtime/main-9aaac9a75d32bea46c8c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <script src="/_next/static/runtime/main-2132027b05a4c8c684f5.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-2132027b05a4c8c684f5.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -56,9 +56,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
+        <script src="/_next/static/runtime/main-9aaac9a75d32bea46c8c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <script src="/_next/static/runtime/main-2132027b05a4c8c684f5.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-2132027b05a4c8c684f5.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -54,9 +54,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.119f7caa0f0e5f3f7629.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
+        <script src="/_next/static/runtime/main-9aaac9a75d32bea46c8c.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
+        <script src="/_next/static/runtime/main-2132027b05a4c8c684f5.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	14.4s	14.7s	⚠️ +256ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	18.9 kB	18.9 kB	⚠️ +2 B
main-HASH.js gzip	6.79 kB	6.79 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..6604acae7.js	43.2 kB	43.2 kB	✓
de003c3a9d30..cae7.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	17.2 kB	17.2 kB	⚠️ +2 B
main-HASH.module.js gzip	6.52 kB	6.52 kB	⚠️ +4 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..42.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	zekchan/next.js master	Change
_error.js	253 kB	253 kB	✓
_error.js gzip	67.9 kB	67.9 kB	⚠️ +4 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	980 B	978 B	-2 B
index.js	254 kB	254 kB	✓
index.js gzip	68.2 kB	68.2 kB	⚠️ +4 B
link.js	261 kB	261 kB	✓
link.js gzip	70.3 kB	70.3 kB	⚠️ +3 B
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.3 kB	68.3 kB	⚠️ +4 B
withRouter.js	254 kB	254 kB	✓
withRouter.js gzip	68.4 kB	68.4 kB	⚠️ +4 B
Overall change	1.28 MB	1.28 MB	✓

Commit: 8afb76d

Timer

Can you please add a test for this? Thanks!

ijjk · 2019-10-30T14:13:03Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	15.7s	16.1s	⚠️ +383ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	16.6 kB	16.6 kB	⚠️ +2 B
main-HASH.js gzip	5.85 kB	5.86 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	14 kB	14 kB	⚠️ +2 B
main-HASH.module.js gzip	5.25 kB	5.25 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	zekchan/next.js master	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	⚠️ +2 B
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	⚠️ +2 B
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	⚠️ +2 B
Overall change	12.9 kB	12.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -1456,7 +1456,7 @@ function () {
                   scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
                 }
 
-                url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+                url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
                 // its own deduping mechanism.
 
                 if (!document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for main-HASH.module.js

@@ -1252,7 +1252,7 @@ class PageLoader {
         scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
       }
 
-      var url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+      var url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
       // its own deduping mechanism.
 
       if (document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for index.html

@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-818b1fda7911dc5f9ce3.js"
+        <script src="/_next/static/runtime/main-68a9a054b867503f7696.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <script src="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.219514909c9db8a9ff76.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -20,7 +20,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -66,9 +66,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-818b1fda7911dc5f9ce3.js"
+        <script src="/_next/static/runtime/main-68a9a054b867503f7696.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <script src="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -20,7 +20,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -64,9 +64,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-818b1fda7911dc5f9ce3.js"
+        <script src="/_next/static/runtime/main-68a9a054b867503f7696.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <script src="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	16.1s	15.9s	-194ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	16.6 kB	16.6 kB	⚠️ +2 B
main-HASH.js gzip	5.85 kB	5.86 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	14 kB	14 kB	⚠️ +2 B
main-HASH.module.js gzip	5.25 kB	5.25 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	zekchan/next.js master	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	⚠️ +4 B
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	⚠️ +3 B
link.js	274 kB	274 kB	✓
link.js gzip	73.5 kB	73.5 kB	⚠️ +3 B
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	⚠️ +4 B
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	⚠️ +3 B
Overall change	1.29 MB	1.29 MB	✓

Commit: 7d63b4e

ijjk · 2019-10-30T14:15:55Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	17.4s	17.2s	-195ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	16.6 kB	16.6 kB	⚠️ +2 B
main-HASH.js gzip	5.85 kB	5.86 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	14 kB	14 kB	⚠️ +2 B
main-HASH.module.js gzip	5.25 kB	5.25 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	zekchan/next.js master	Change
index.html	3.94 kB	3.94 kB	✓
index.html gzip	1 kB	1 kB	⚠️ +2 B
link.html	4.47 kB	4.47 kB	✓
link.html gzip	1.08 kB	1.08 kB	⚠️ +2 B
withRouter.html	4.47 kB	4.47 kB	✓
withRouter.html gzip	1.07 kB	1.07 kB	⚠️ +2 B
Overall change	12.9 kB	12.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -1456,7 +1456,7 @@ function () {
                   scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
                 }
 
-                url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+                url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
                 // its own deduping mechanism.
 
                 if (!document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for main-HASH.module.js

@@ -1252,7 +1252,7 @@ class PageLoader {
         scriptRoute = scriptRoute.replace(/\.js$/, '.module.js');
       }
 
-      var url = isDependency ? route : _this2.assetPrefix + "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute; // n.b. If preload is not supported, we fall back to `loadPage` which has
+      var url = _this2.assetPrefix + (isDependency ? route : "/_next/static/" + encodeURIComponent(_this2.buildId) + "/pages" + scriptRoute); // n.b. If preload is not supported, we fall back to `loadPage` which has
       // its own deduping mechanism.
 
       if (document.querySelector("link[rel=\"preload\"][href^=\"" + url + "\"], script[data-next-page=\"" + route + "\"]")) {

Diff for index.html

@@ -12,7 +12,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-818b1fda7911dc5f9ce3.js"
+        <script src="/_next/static/runtime/main-68a9a054b867503f7696.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <script src="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.219514909c9db8a9ff76.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -20,7 +20,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -66,9 +66,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-818b1fda7911dc5f9ce3.js"
+        <script src="/_next/static/runtime/main-68a9a054b867503f7696.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <script src="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -20,7 +20,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -64,9 +64,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-818b1fda7911dc5f9ce3.js"
+        <script src="/_next/static/runtime/main-68a9a054b867503f7696.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-faa5e1ddde710d52391c.module.js"
+        <script src="/_next/static/runtime/main-d5e41e2fb883a03fc72a.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
buildDuration	17.5s	17.7s	⚠️ +266ms
nodeModulesSize	48.4 MB	48.4 MB	⚠️ +24 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.js	16.6 kB	16.6 kB	⚠️ +2 B
main-HASH.js gzip	5.85 kB	5.86 kB	⚠️ +4 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..63e75d588.js	19.7 kB	19.7 kB	✓
16b1a7225520..d588.js gzip	7.23 kB	7.23 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..9e9c1d310.js	28.6 kB	28.6 kB	✓
de003c3a9d30..d310.js gzip	10.8 kB	10.8 kB	✓
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
Overall change	214 kB	214 kB	⚠️ +2 B

Client Bundles (main, webpack, commons) Modern Overall increase ⚠️

	zeit/next.js canary	zekchan/next.js master	Change
main-HASH.module.js	14 kB	14 kB	⚠️ +2 B
main-HASH.module.js gzip	5.25 kB	5.25 kB	⚠️ +3 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..51.module.js	15.8 kB	15.8 kB	✓
16b1a7225520..dule.js gzip	6.06 kB	6.06 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..c0.module.js	22.1 kB	22.1 kB	✓
de003c3a9d30..dule.js gzip	8.67 kB	8.67 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	192 kB	192 kB	⚠️ +2 B

Client Pages

	zeit/next.js canary	zekchan/next.js master	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	zekchan/next.js master	Change
_app.module.js	1.53 kB	1.53 kB	✓
_app.module.js gzip	749 B	749 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.47 kB	5.47 kB	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.1 kB	20.1 kB	✓

Client Build Manifests

	zeit/next.js canary	zekchan/next.js master	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	199 B	199 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	210 B	210 B	✓
Overall change	495 B	495 B	✓

Serverless bundles

	zeit/next.js canary	zekchan/next.js master	Change
_error.js	241 kB	241 kB	✓
_error.js gzip	64.4 kB	64.4 kB	⚠️ +4 B
hooks.html	4.08 kB	4.08 kB	✓
hooks.html gzip	1.03 kB	1.03 kB	✓
index.js	241 kB	241 kB	✓
index.js gzip	64.5 kB	64.5 kB	⚠️ +3 B
link.js	274 kB	274 kB	✓
link.js gzip	73.5 kB	73.5 kB	⚠️ +3 B
routerDirect.js	267 kB	267 kB	✓
routerDirect.js gzip	71.5 kB	71.5 kB	⚠️ +4 B
withRouter.js	267 kB	267 kB	✓
withRouter.js gzip	71.6 kB	71.6 kB	⚠️ +3 B
Overall change	1.29 MB	1.29 MB	✓

Commit: 2bddad9

zekchan requested review from ijjk, lfades, Timer and timneutkens as code owners October 8, 2019 13:43

closes vercel#8989

084c5ec

fix closes vercel#8989

zekchan force-pushed the master branch from 084adf6 to 084c5ec Compare October 8, 2019 14:43

Merge branch 'canary' into master

8afb76d

Timer changed the title ~~closes #8989~~ Load granular chunks with correct asset prefix Oct 16, 2019

Timer added priority: low labels Oct 16, 2019

Timer added this to the 9.1.x milestone Oct 16, 2019

Timer requested changes Oct 16, 2019

View reviewed changes

zekchan added 2 commits October 17, 2019 18:24

Merge branch 'canary' of github.com:zeit/next.js

ed820a8

test

f9f30f3

zekchan changed the title ~~Load granular chunks with correct asset prefix~~ [WIP] Load granular chunks with correct asset prefix Oct 18, 2019

Timer modified the milestones: 9.1.x, 9.1.2, 9.1.3 Oct 28, 2019

Timer and others added 7 commits October 30, 2019 09:59

Update next.config.js

12b46dc

Revert page1.js

75d1568

Revert page2.js

7d86da0

Delete page4.js

b79a1f3

Delete page3.js

476d8e9

Update index.test.js

81f865c

Merge branch 'canary' into master

7d63b4e

Timer added 2 commits October 30, 2019 10:09

Revert index.test.js

271c946

Revert next.config.js

2bddad9

Timer changed the title ~~[WIP] Load granular chunks with correct asset prefix~~ Load granular chunks with correct asset prefix Oct 30, 2019

Timer added the ready to land label Oct 30, 2019

Timer approved these changes Oct 30, 2019

View reviewed changes

Timer merged commit 8dd394a into vercel:canary Oct 30, 2019

This was referenced Nov 19, 2019

[Snyk] Upgrade next from 9.1.2 to 9.1.3 ndom91/newtelco-next-maintenance-mgmt#10

Merged

[Snyk] Upgrade next from 9.0.4 to 9.1.3 ajesse11x/now-examples#17

Open

bmathews mentioned this pull request Jan 4, 2020

Add assetPrefix when fetching script and style dependencies #9933

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Load granular chunks with correct asset prefix #8993

Load granular chunks with correct asset prefix #8993

zekchan commented Oct 8, 2019 •

edited by Timer

Loading

ijjk commented Oct 8, 2019

ijjk commented Oct 8, 2019

Diffs

ijjk commented Oct 8, 2019

Diffs

ijjk commented Oct 9, 2019

Diffs

Timer left a comment

ijjk commented Oct 30, 2019

Diffs

ijjk commented Oct 30, 2019

Diffs

Load granular chunks with correct asset prefix #8993

Load granular chunks with correct asset prefix #8993

Conversation

zekchan commented Oct 8, 2019 • edited by Timer Loading

ijjk commented Oct 8, 2019

Stats from current PR

ijjk commented Oct 8, 2019

Stats from current PR

Diffs

ijjk commented Oct 8, 2019

Stats from current PR

Diffs

ijjk commented Oct 9, 2019

Stats from current PR

Diffs

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Oct 30, 2019

Stats from current PR

Diffs

ijjk commented Oct 30, 2019

Stats from current PR

Diffs

zekchan commented Oct 8, 2019 •

edited by Timer

Loading