Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Lockfile #9158

Merged
merged 6 commits into from
Oct 22, 2019
Merged

Upgrade Lockfile #9158

merged 6 commits into from
Oct 22, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Oct 22, 2019

This upgrades our lock file in hopes of getting tests to pass again. There's an annoying browserslist message that throws when its not updated for 6 months.

Also, these versions are what our users get anyway. Doesn't hurt to upgrade.


I've disabled AMP tests since AMP is broken right now.

@Timer Timer added this to the 9.1.2 milestone Oct 22, 2019
@Timer
Copy link
Member Author

Timer commented Oct 22, 2019

We're further blocked by a botched AMP package publish, it seems.

ampproject/amphtml#25188

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as discussed a follow up PR will re-enable AMP tests and be auto-merged when it's fixed upstream

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants