Update examples: static export using dynamic routes instead express #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliyakarat
force-pushed
the
update-example-static-export
branch
from
bb3310e
to
8dd9417
Compare
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons) Overall decrease ✓
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
DiffsDiff for main-HASH.js@@ -340,7 +340,7 @@ if (!window.Promise) {
var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
window.__NEXT_DATA__ = data;
-var version = "9.1.2-canary.10";
+var version = "9.1.2-canary.9";
exports.version = version;
var props = data.props,
err = data.err,Diff for main-HASH.module.js@@ -339,7 +339,7 @@ if (!window.Promise) {
var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
window.__NEXT_DATA__ = data;
-var version = "9.1.2-canary.10";
+var version = "9.1.2-canary.9";
exports.version = version;
var {
props,Diff for index.html@@ -12,7 +12,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-a085a6c64ecf07be5320.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-11265a5ef9be647fbeaa.module.js"
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-b03421a7dc68f3d2666e.js"
+ <script src="/_next/static/runtime/main-3ec75919f469510f6b3b.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-a085a6c64ecf07be5320.module.js"
+ <script src="/_next/static/runtime/main-11265a5ef9be647fbeaa.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/chunks/framework.219514909c9db8a9ff76.js"
async="" crossorigin="anonymous" nomodule=""></script>Diff for link.html@@ -20,7 +20,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-a085a6c64ecf07be5320.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-11265a5ef9be647fbeaa.module.js"
as="script" crossorigin="anonymous" />
</head>
@@ -66,9 +66,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-b03421a7dc68f3d2666e.js"
+ <script src="/_next/static/runtime/main-3ec75919f469510f6b3b.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-a085a6c64ecf07be5320.module.js"
+ <script src="/_next/static/runtime/main-11265a5ef9be647fbeaa.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Diff for withRouter.html@@ -20,7 +20,7 @@
as="script" crossorigin="anonymous" />
<link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
as="script" crossorigin="anonymous" />
- <link rel="preload" href="/_next/static/runtime/main-a085a6c64ecf07be5320.module.js"
+ <link rel="preload" href="/_next/static/runtime/main-11265a5ef9be647fbeaa.module.js"
as="script" crossorigin="anonymous" />
</head>
@@ -64,9 +64,9 @@
async="" crossorigin="anonymous" nomodule=""></script>
<script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.8d1caa0eed52bc802a38.module.js"
async="" crossorigin="anonymous" type="module"></script>
- <script src="/_next/static/runtime/main-b03421a7dc68f3d2666e.js"
+ <script src="/_next/static/runtime/main-3ec75919f469510f6b3b.js"
async="" crossorigin="anonymous" nomodule=""></script>
- <script src="/_next/static/runtime/main-a085a6c64ecf07be5320.module.js"
+ <script src="/_next/static/runtime/main-11265a5ef9be647fbeaa.module.js"
async="" crossorigin="anonymous" type="module"></script>
<script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
crossorigin="anonymous" nomodule=""></script>Serverless Mode (Decrease detected ✓)General Overall decrease ✓
Client Bundles (main, webpack, commons) Overall decrease ✓
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: bb3310e |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 8dd9417 |
ijjk
reviewed
Oct 29, 2019
| @@ -13,7 +13,7 @@ module.exports = { | |||
| (pages, post) => | |||
| Object.assign({}, pages, { | |||
| [`/post/${post.id}`]: { | |||
| page: '/post', | |||
| page: '/post/[id]', | |||
| query: { id: post.id } | |||
There was a problem hiding this comment.
Suggested change
| query: { id: post.id } |
We should be able to remove this since we parse/provide it for dynamic routes automatically
There was a problem hiding this comment.
yea, good point, I'll check it
timneutkens
approved these changes
Oct 29, 2019
|
Awesome @meuwka! |
This was referenced Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.