Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CorrectionPeriod in market stages #6

Open
Robiquet opened this issue Jan 25, 2023 · 2 comments
Open

Handle CorrectionPeriod in market stages #6

Robiquet opened this issue Jan 25, 2023 · 2 comments

Comments

@Robiquet
Copy link
Member

Feel free to close this if you already have it covered but there is a change in the new runtime that might need to be accounted for

From change log:

"The market dispute mechanisms are now able to control their resolution. The CorrectionPeriod parameter determines how long the authorized pallet can call authorize_market_outcome again after the first call to it (fat-finger protection). The authority report now includes its resolution block number. This is the time of the first call to authorize_market_outcome plus the CorrectionPeriod."

https://github.com/zeitgeistpm/zeitgeist/blob/main/docs/changelog_for_devs.md

@yornaath
Copy link
Collaborator

There is also a possible fix for this coming in the next version where it tries to read from constants but defaults to one day. Does that seem correct? Meaning what is the default now when the constant isnt in place on battery station yet?

@Robiquet
Copy link
Member Author

Not sure we need to have a hardcoded fall back. Battery station is still on 0.3.7, I think it will be upgraded this week

Though if you want to add a fallback I think 1 day is correct, though best to check with the runtime team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants