Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when catting random bytes #1346

Closed
Tracked by #1100
raphCode opened this issue Apr 25, 2022 · 1 comment
Closed
Tracked by #1100

Crash when catting random bytes #1346

raphCode opened this issue Apr 25, 2022 · 1 comment
Labels
stability Issues in relation to stability

Comments

@raphCode
Copy link
Contributor

While filing #1345, I reliably got some crashes on zellij v0.28.1.
Do a cat /dev/urandom inside zellij, after some seconds to minutes I hit:

Error occurred in server:

  × Thread 'screen' panicked.
  ├─▶ Originating Thread(s)
  │   	1. screen_thread: HandlePtyBytes
  │
  ├─▶ At zellij-server/src/panes/grid.rs:1543:46
  ╰─▶ index out of bounds: the len is 1 but the index is 1
@a-kenji a-kenji added the stability Issues in relation to stability label Apr 25, 2022
@imsnif
Copy link
Member

imsnif commented Apr 26, 2022

Yeah, both this and #1345 are regressions unfortunately. I used to do exactly these sorts of tests in the early days :)
I'll do another round this week to patch things up and hopefully soon we'll add some proper error handling there so that even if this happens, at worst the specific terminal pane will glitch a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability Issues in relation to stability
Projects
None yet
Development

No branches or pull requests

3 participants