Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-Shift-v not working for git SSH key passphrase #1687

Closed
dr-kristau opened this issue Aug 23, 2022 · 8 comments · Fixed by #1689
Closed

Ctrl-Shift-v not working for git SSH key passphrase #1687

dr-kristau opened this issue Aug 23, 2022 · 8 comments · Fixed by #1689

Comments

@dr-kristau
Copy link

zellij --version: zellij 0.31.3
stty size: 36 160
uname -av: Linux jupiter 5.18.17-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Aug 11 14:36:06 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

gnome-terminal: Version 3.44.1 for GNOME 42
bash: GNU bash, version 5.1.16(1)-release (x86_64-redhat-linux-gnu)
git: git version 2.37.2
openssh: OpenSSH_8.8p1, OpenSSL 3.0.5 5 Jul 2022

I discovered this issue when attempting $ git pull on one of my repos—I cannot paste (using Ctrl+Shift+v) my passphrase into zellij when the Enter passphrase for key '/home/xxx/.ssh/id_edxxx': prompt appears. When I quit zellij (Ctrl+q) and retry, it works as expected.

@tlinford
Copy link
Contributor

could it be that the key is not getting copied into the clipboard?

@dr-kristau
Copy link
Author

Thanks for the suggestion @tlinford. Just to clarify then, that when I say 'when I quit zellij (Ctrl+q) and retry' I don't copy anything new to the clipboard—I use what was already there and that should have been pasted into the passphrase prompt within zellij.

@tlinford
Copy link
Contributor

and apart from this can you can paste normally?

@dr-kristau
Copy link
Author

Yes. I can paste my SSH key password into the default prompt [xxxx@yyyy ~]$ and it will appear as expected. In my experience, this issue only happens at the SSH key passphrase prompt as described.

@raphCode
Copy link
Contributor

Maybe this is related to bracketed paste?
Like somehow we send a bracketed paste where ssh doesn't expect it disallows pasting. Pasting without bracketed paste involves the terminal emulator sending the text as if the user typed it, so there are no problems.
If my theory is correct, this can be caused by:

  • a bug in zellij's bracketed paste tracking logic
  • an application which requested bracketed paste earlier on the same terminal, but it crashed / exited without a chance to disable bracketed paste again

@dr-kristau
Copy link
Author

an application which requested bracketed paste earlier on the same terminal, but it crashed / exited without a chance to disable bracketed paste again

fyi @raphCode: to make sure I could reproduced the issue, I logged out of my account before running the test. On login I opened the GNOME terminal (with eval "$(zellij setup --generate-auto-start bash)" in .bashrc), navigated to the git repo and ran $ git pull directly. Which is to say that that while possible that a crash had happened in the same terminal before I ran $ git pull and tried to paste my password into the passphrase prompt, I would say that it is unlikely.

@ovitor
Copy link

ovitor commented Aug 24, 2022

I'm also having the same issue. Every time I try to use ssh inside zellij it "doesn't allow" me to paste my ssh key's passphrase.

vitor in ~ ❯ zellij --version                                                                                                          
zellij 0.31.3

@tlinford
Copy link
Contributor

Couldn't reproduce it, then I noticed it was still on 0.31.0.
Turns out there was a regression in 0.31.2 due to some code cleanup, that slightly broke the bracketed paste handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants