Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make brown-slave not one of the valid randomly generated names for a session #2676

Closed
gamma-delta opened this issue Aug 6, 2023 · 4 comments

Comments

@gamma-delta
Copy link

image

Yeouch!

@gamma-delta
Copy link
Author

Huh, looking at the list of nouns it looks like slave isn't in there (thank god)

https://github.com/zellij-org/zellij/blob/main/src/sessions.rs#L303

Which is weird, because I'm on v0.37.2.

@gamma-delta
Copy link
Author

... huh, it is one of the default words in the names crate but Zellij should be providing its own list.

https://github.com/fnichol/names/blob/main/data/nouns.txt#L770

Maybe I should go file a report on their repo but it is odd that it is using their list instead of the list you pass.

@gamma-delta
Copy link
Author

The latest version of names is 0.14.1 and zellij is using 0.14.0 but it looks like it just bumps dependencies.

@tlinford
Copy link
Contributor

tlinford commented Aug 7, 2023

This has been addressed in #2122. It's in main and will be included in the next release :)

@tlinford tlinford closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants