Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout's exact file location are not exposed to plugins. NewTabsWithLayout only takes ready made layout data. #3291

Closed
CraigglesO opened this issue Apr 23, 2024 · 2 comments
Closed

Layout's exact file location are not exposed to plugins. NewTabsWithLayout only takes ready made layout data. #3291

CraigglesO opened this issue Apr 23, 2024 · 2 comments
Assignees
@imsnif

Comments

@CraigglesO
Copy link

Currently, the API has a function NewTabsWithLayout that requires a layout to be passed in. However, each session stores layouts as LayoutInfo which gives the name but not the file location. The best case for me is to either add another function or update NewTabsWithLayout to use the name and grab the layout information from the file for the plugin.
@imsnif imsnif self-assigned this Apr 23, 2024
@imsnif imsnif mentioned this issue Apr 26, 2024
Merged
@imsnif
Copy link
Member

imsnif commented Apr 26, 2024

Implemented in #3305 - thanks for your feedback!

@imsnif imsnif closed this as completed Apr 26, 2024
@CraigglesO
Copy link
Author

You both exposed new_tabs_with_layout_info AND layout_dir really quickly. Wow sir you are awesome. TYSM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imsnif imsnif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imsnif @CraigglesO