Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kakoune editor shows incorrect colors #613

Closed
chrisboyce opened this issue Jul 9, 2021 · 2 comments
Closed

Kakoune editor shows incorrect colors #613

chrisboyce opened this issue Jul 9, 2021 · 2 comments
Labels
compatibility Issues with VT/terminal compatibility suspected bug

Comments

@chrisboyce
Copy link

When using kakoune from within a zellij instance, the terminal does not show the expected colors. Attached towards the bottom are screenshots of kakoune without zellij (the tan color) and within zellij (the dark blue).

Debug Logs
zellij-15.log
zellij-10.log
zellij-9.log

Basic information

zellij --version: 0.15.0
tput lines: 34
tput cols: 119
uname -av or ver(Windows): Linux blamblam 5.8.0-59-generic #66~20.04.1-Ubuntu SMP Thu Jun 17 11:14:10 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

List of programs you interact with as, PROGRAM --version: output cropped meaningful, for example:
kak -version: Kakoune v2020.09.01-578-gcac946b4
alacritty --version: 0.8.0

Further information
Screenshot of kakoune from an alacritty terminal without zellij
image

Screenshot of kakoune from an alacritty terminal with zellij
image

From the kakoune Discord chat:

Kakoune by default uses a palette-switching method to get true colors (outside 256 terminal ones), which might not be working well with zellij. There is an alternative branch builtin-terminal-ui that uses 24-bit color sequences directly, assuming that the terminal supports it. Last I saw it mentioned (#385) it is supposed to be working well with zellij, so you can give it a try.

If I build kakoune from the builtin-terminal-ui branch as suggested, zellij does show the expected colors.

@a-kenji a-kenji added the compatibility Issues with VT/terminal compatibility label Jul 9, 2021
@chrisboyce
Copy link
Author

Looking through the commit history, I think that #453 fixed the issue for some people. However if I check out 1f88b34 I'm still seeing the issue, so I don't think this is a regression.

@imsnif
Copy link
Member

imsnif commented Aug 13, 2021

Hey @chrisboyce - this is now fixed in main. Thanks for the report! I hope to release a new version with this sometime next week. Will close this now - if this still happens to you in the next release, please ping me and I'll re-open.

@imsnif imsnif closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Issues with VT/terminal compatibility suspected bug
Projects
None yet
Development

No branches or pull requests

3 participants