From daa04148edeed385e3263429fe8a56b2e053de62 Mon Sep 17 00:00:00 2001
From: Aram Drevekenin <aram@poor.dev>
Date: Fri, 25 Aug 2023 15:49:20 +0200
Subject: [PATCH 1/2] fix(keybinds): add 'floating' and 'name' to the Run
 command keybinding

---
 zellij-utils/src/kdl/mod.rs | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/zellij-utils/src/kdl/mod.rs b/zellij-utils/src/kdl/mod.rs
index 1d09bdac52..9cf93f1237 100644
--- a/zellij-utils/src/kdl/mod.rs
+++ b/zellij-utils/src/kdl/mod.rs
@@ -870,6 +870,9 @@ impl TryFrom<(&KdlNode, &Options)> for Action {
                 let cwd = command_metadata
                     .and_then(|c_m| kdl_child_string_value_for_entry(c_m, "cwd"))
                     .map(|cwd_string| PathBuf::from(cwd_string));
+                let name = command_metadata
+                    .and_then(|c_m| kdl_child_string_value_for_entry(c_m, "name"))
+                    .map(|name_string| name_string.to_string());
                 let direction = command_metadata
                     .and_then(|c_m| kdl_child_string_value_for_entry(c_m, "direction"))
                     .and_then(|direction_string| Direction::from_str(direction_string).ok());
@@ -880,6 +883,9 @@ impl TryFrom<(&KdlNode, &Options)> for Action {
                 let hold_on_start = command_metadata
                     .and_then(|c_m| kdl_child_bool_value_for_entry(c_m, "start_suspended"))
                     .unwrap_or(false);
+                let floating = command_metadata
+                    .and_then(|c_m| kdl_child_bool_value_for_entry(c_m, "floating"))
+                    .unwrap_or(false);
                 let run_command_action = RunCommandAction {
                     command: PathBuf::from(command),
                     args,
@@ -888,7 +894,18 @@ impl TryFrom<(&KdlNode, &Options)> for Action {
                     hold_on_close,
                     hold_on_start,
                 };
-                Ok(Action::Run(run_command_action))
+                if floating {
+                    Ok(Action::NewFloatingPane(
+                        Some(run_command_action),
+                        name,
+                    ))
+                } else {
+                    Ok(Action::NewTiledPane(
+                        direction,
+                        Some(run_command_action),
+                        name,
+                    ))
+                }
             },
             "LaunchOrFocusPlugin" => {
                 let arguments = action_arguments.iter().copied();

From 235e3bb9fbb8503530f03d3227956d734ac92e83 Mon Sep 17 00:00:00 2001
From: Aram Drevekenin <aram@poor.dev>
Date: Fri, 25 Aug 2023 15:49:35 +0200
Subject: [PATCH 2/2] style(fmt): rustfmt

---
 zellij-utils/src/kdl/mod.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/zellij-utils/src/kdl/mod.rs b/zellij-utils/src/kdl/mod.rs
index 9cf93f1237..a7573af55a 100644
--- a/zellij-utils/src/kdl/mod.rs
+++ b/zellij-utils/src/kdl/mod.rs
@@ -895,10 +895,7 @@ impl TryFrom<(&KdlNode, &Options)> for Action {
                     hold_on_start,
                 };
                 if floating {
-                    Ok(Action::NewFloatingPane(
-                        Some(run_command_action),
-                        name,
-                    ))
+                    Ok(Action::NewFloatingPane(Some(run_command_action), name))
                 } else {
                     Ok(Action::NewTiledPane(
                         direction,