From 2c147bc3b49ea708c32870b8a64c9c75920a72f5 Mon Sep 17 00:00:00 2001 From: zemyblue Date: Wed, 8 May 2024 12:48:16 +0900 Subject: [PATCH] chore: remove unnecessary encoder unittests. Signed-off-by: zemyblue --- app/wasm_filter_test.go | 480 +--------------------------------------- 1 file changed, 2 insertions(+), 478 deletions(-) diff --git a/app/wasm_filter_test.go b/app/wasm_filter_test.go index 84cece92..c6075732 100644 --- a/app/wasm_filter_test.go +++ b/app/wasm_filter_test.go @@ -3,9 +3,6 @@ package app import ( "testing" - ibctransfertypes "github.com/cosmos/ibc-go/v4/modules/apps/transfer/types" - clienttypes "github.com/cosmos/ibc-go/v4/modules/core/02-client/types" - channeltypes "github.com/cosmos/ibc-go/v4/modules/core/04-channel/types" "github.com/golang/protobuf/proto" // nolint: staticcheck "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" @@ -13,29 +10,22 @@ import ( codectypes "github.com/Finschia/finschia-sdk/codec/types" sdk "github.com/Finschia/finschia-sdk/types" banktypes "github.com/Finschia/finschia-sdk/x/bank/types" - distributiontypes "github.com/Finschia/finschia-sdk/x/distribution/types" govtypes "github.com/Finschia/finschia-sdk/x/gov/types" - stakingtypes "github.com/Finschia/finschia-sdk/x/staking/types" wasmkeeper "github.com/Finschia/wasmd/x/wasm/keeper" - "github.com/Finschia/wasmd/x/wasm/keeper/wasmtesting" wasmtypes "github.com/Finschia/wasmd/x/wasm/types" wasmvmtypes "github.com/Finschia/wasmvm/types" ) func TestFilteredStargateMsgEncoders(t *testing.T) { var ( - addr1 = wasmkeeper.RandomAccountAddress(t) - addr2 = wasmkeeper.RandomAccountAddress(t) - addr3 = wasmkeeper.RandomAccountAddress(t) - invalidAddr = "xrnd1d02kd90n38qvr3qb9qof83fn2d2" + addr1 = wasmkeeper.RandomAccountAddress(t) + addr2 = wasmkeeper.RandomAccountAddress(t) ) valAddr := make(sdk.ValAddress, wasmtypes.SDKAddrLen) valAddr[0] = 12 valAddr2 := make(sdk.ValAddress, wasmtypes.SDKAddrLen) valAddr2[1] = 123 - jsonMsg := wasmtypes.RawContractMessage(`{"foo": 123}`) - bankMsg := &banktypes.MsgSend{ FromAddress: addr2.String(), ToAddress: addr1.String(), @@ -68,288 +58,6 @@ func TestFilteredStargateMsgEncoders(t *testing.T) { // set if invalid isError bool }{ - "simple send": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Bank: &wasmvmtypes.BankMsg{ - Send: &wasmvmtypes.SendMsg{ - ToAddress: addr2.String(), - Amount: []wasmvmtypes.Coin{ - { - Denom: "uatom", - Amount: "12345", - }, - { - Denom: "usdt", - Amount: "54321", - }, - }, - }, - }, - }, - output: []sdk.Msg{ - &banktypes.MsgSend{ - FromAddress: addr1.String(), - ToAddress: addr2.String(), - Amount: sdk.Coins{ - sdk.NewInt64Coin("uatom", 12345), - sdk.NewInt64Coin("usdt", 54321), - }, - }, - }, - }, - "invalid send amount": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Bank: &wasmvmtypes.BankMsg{ - Send: &wasmvmtypes.SendMsg{ - ToAddress: addr2.String(), - Amount: []wasmvmtypes.Coin{ - { - Denom: "uatom", - Amount: "123.456", - }, - }, - }, - }, - }, - isError: true, - }, - "invalid address": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Bank: &wasmvmtypes.BankMsg{ - Send: &wasmvmtypes.SendMsg{ - ToAddress: invalidAddr, - Amount: []wasmvmtypes.Coin{ - { - Denom: "uatom", - Amount: "7890", - }, - }, - }, - }, - }, - isError: false, // addresses are checked in the handler - output: []sdk.Msg{ - &banktypes.MsgSend{ - FromAddress: addr1.String(), - ToAddress: invalidAddr, - Amount: sdk.Coins{ - sdk.NewInt64Coin("uatom", 7890), - }, - }, - }, - }, - "wasm execute": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Wasm: &wasmvmtypes.WasmMsg{ - Execute: &wasmvmtypes.ExecuteMsg{ - ContractAddr: addr2.String(), - Msg: jsonMsg, - Funds: []wasmvmtypes.Coin{ - wasmvmtypes.NewCoin(12, "eth"), - }, - }, - }, - }, - output: []sdk.Msg{ - &wasmtypes.MsgExecuteContract{ - Sender: addr1.String(), - Contract: addr2.String(), - Msg: jsonMsg, - Funds: sdk.NewCoins(sdk.NewInt64Coin("eth", 12)), - }, - }, - }, - "wasm instantiate": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Wasm: &wasmvmtypes.WasmMsg{ - Instantiate: &wasmvmtypes.InstantiateMsg{ - CodeID: 7, - Msg: jsonMsg, - Funds: []wasmvmtypes.Coin{ - wasmvmtypes.NewCoin(123, "eth"), - }, - Label: "myLabel", - Admin: addr2.String(), - }, - }, - }, - output: []sdk.Msg{ - &wasmtypes.MsgInstantiateContract{ - Sender: addr1.String(), - CodeID: 7, - Label: "myLabel", - Msg: jsonMsg, - Funds: sdk.NewCoins(sdk.NewInt64Coin("eth", 123)), - Admin: addr2.String(), - }, - }, - }, - "wasm migrate": { - sender: addr2, - srcMsg: wasmvmtypes.CosmosMsg{ - Wasm: &wasmvmtypes.WasmMsg{ - Migrate: &wasmvmtypes.MigrateMsg{ - ContractAddr: addr1.String(), - NewCodeID: 12, - Msg: jsonMsg, - }, - }, - }, - output: []sdk.Msg{ - &wasmtypes.MsgMigrateContract{ - Sender: addr2.String(), - Contract: addr1.String(), - CodeID: 12, - Msg: jsonMsg, - }, - }, - }, - "wasm update admin": { - sender: addr2, - srcMsg: wasmvmtypes.CosmosMsg{ - Wasm: &wasmvmtypes.WasmMsg{ - UpdateAdmin: &wasmvmtypes.UpdateAdminMsg{ - ContractAddr: addr1.String(), - Admin: addr3.String(), - }, - }, - }, - output: []sdk.Msg{ - &wasmtypes.MsgUpdateAdmin{ - Sender: addr2.String(), - Contract: addr1.String(), - NewAdmin: addr3.String(), - }, - }, - }, - "wasm clear admin": { - sender: addr2, - srcMsg: wasmvmtypes.CosmosMsg{ - Wasm: &wasmvmtypes.WasmMsg{ - ClearAdmin: &wasmvmtypes.ClearAdminMsg{ - ContractAddr: addr1.String(), - }, - }, - }, - output: []sdk.Msg{ - &wasmtypes.MsgClearAdmin{ - Sender: addr2.String(), - Contract: addr1.String(), - }, - }, - }, - "staking delegate": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Staking: &wasmvmtypes.StakingMsg{ - Delegate: &wasmvmtypes.DelegateMsg{ - Validator: valAddr.String(), - Amount: wasmvmtypes.NewCoin(777, "stake"), - }, - }, - }, - output: []sdk.Msg{ - &stakingtypes.MsgDelegate{ - DelegatorAddress: addr1.String(), - ValidatorAddress: valAddr.String(), - Amount: sdk.NewInt64Coin("stake", 777), - }, - }, - }, - "staking delegate to non-validator": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Staking: &wasmvmtypes.StakingMsg{ - Delegate: &wasmvmtypes.DelegateMsg{ - Validator: addr2.String(), - Amount: wasmvmtypes.NewCoin(777, "stake"), - }, - }, - }, - isError: false, // fails in the handler - output: []sdk.Msg{ - &stakingtypes.MsgDelegate{ - DelegatorAddress: addr1.String(), - ValidatorAddress: addr2.String(), - Amount: sdk.NewInt64Coin("stake", 777), - }, - }, - }, - "staking undelegate": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Staking: &wasmvmtypes.StakingMsg{ - Undelegate: &wasmvmtypes.UndelegateMsg{ - Validator: valAddr.String(), - Amount: wasmvmtypes.NewCoin(555, "stake"), - }, - }, - }, - output: []sdk.Msg{ - &stakingtypes.MsgUndelegate{ - DelegatorAddress: addr1.String(), - ValidatorAddress: valAddr.String(), - Amount: sdk.NewInt64Coin("stake", 555), - }, - }, - }, - "staking redelegate": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Staking: &wasmvmtypes.StakingMsg{ - Redelegate: &wasmvmtypes.RedelegateMsg{ - SrcValidator: valAddr.String(), - DstValidator: valAddr2.String(), - Amount: wasmvmtypes.NewCoin(222, "stake"), - }, - }, - }, - output: []sdk.Msg{ - &stakingtypes.MsgBeginRedelegate{ - DelegatorAddress: addr1.String(), - ValidatorSrcAddress: valAddr.String(), - ValidatorDstAddress: valAddr2.String(), - Amount: sdk.NewInt64Coin("stake", 222), - }, - }, - }, - "staking withdraw (explicit recipient)": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Distribution: &wasmvmtypes.DistributionMsg{ - WithdrawDelegatorReward: &wasmvmtypes.WithdrawDelegatorRewardMsg{ - Validator: valAddr2.String(), - }, - }, - }, - output: []sdk.Msg{ - &distributiontypes.MsgWithdrawDelegatorReward{ - DelegatorAddress: addr1.String(), - ValidatorAddress: valAddr2.String(), - }, - }, - }, - "staking set withdraw address": { - sender: addr1, - srcMsg: wasmvmtypes.CosmosMsg{ - Distribution: &wasmvmtypes.DistributionMsg{ - SetWithdrawAddress: &wasmvmtypes.SetWithdrawAddressMsg{ - Address: addr2.String(), - }, - }, - }, - output: []sdk.Msg{ - &distributiontypes.MsgSetWithdrawAddress{ - DelegatorAddress: addr1.String(), - WithdrawAddress: addr2.String(), - }, - }, - }, "stargate encoded bank msg": { sender: addr2, srcMsg: wasmvmtypes.CosmosMsg{ @@ -380,190 +88,6 @@ func TestFilteredStargateMsgEncoders(t *testing.T) { }, isError: true, }, - "IBC transfer with block timeout": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - IBC: &wasmvmtypes.IBCMsg{ - Transfer: &wasmvmtypes.TransferMsg{ - ChannelID: "myChanID", - ToAddress: addr2.String(), - Amount: wasmvmtypes.Coin{ - Denom: "ALX", - Amount: "1", - }, - Timeout: wasmvmtypes.IBCTimeout{ - Block: &wasmvmtypes.IBCTimeoutBlock{Revision: 1, Height: 2}, - }, - }, - }, - }, - transferPortSource: wasmtesting.MockIBCTransferKeeper{GetPortFn: func(ctx sdk.Context) string { - return "myTransferPort" - }}, - output: []sdk.Msg{ - &ibctransfertypes.MsgTransfer{ - SourcePort: "myTransferPort", - SourceChannel: "myChanID", - Token: sdk.Coin{ - Denom: "ALX", - Amount: sdk.NewInt(1), - }, - Sender: addr1.String(), - Receiver: addr2.String(), - TimeoutHeight: clienttypes.Height{RevisionNumber: 1, RevisionHeight: 2}, - }, - }, - }, - "IBC transfer with time timeout": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - IBC: &wasmvmtypes.IBCMsg{ - Transfer: &wasmvmtypes.TransferMsg{ - ChannelID: "myChanID", - ToAddress: addr2.String(), - Amount: wasmvmtypes.Coin{ - Denom: "ALX", - Amount: "1", - }, - Timeout: wasmvmtypes.IBCTimeout{Timestamp: 100}, - }, - }, - }, - transferPortSource: wasmtesting.MockIBCTransferKeeper{GetPortFn: func(ctx sdk.Context) string { - return "transfer" - }}, - output: []sdk.Msg{ - &ibctransfertypes.MsgTransfer{ - SourcePort: "transfer", - SourceChannel: "myChanID", - Token: sdk.Coin{ - Denom: "ALX", - Amount: sdk.NewInt(1), - }, - Sender: addr1.String(), - Receiver: addr2.String(), - TimeoutTimestamp: 100, - }, - }, - }, - "IBC transfer with time and height timeout": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - IBC: &wasmvmtypes.IBCMsg{ - Transfer: &wasmvmtypes.TransferMsg{ - ChannelID: "myChanID", - ToAddress: addr2.String(), - Amount: wasmvmtypes.Coin{ - Denom: "ALX", - Amount: "1", - }, - Timeout: wasmvmtypes.IBCTimeout{Timestamp: 100, Block: &wasmvmtypes.IBCTimeoutBlock{Height: 1, Revision: 2}}, - }, - }, - }, - transferPortSource: wasmtesting.MockIBCTransferKeeper{GetPortFn: func(ctx sdk.Context) string { - return "transfer" - }}, - output: []sdk.Msg{ - &ibctransfertypes.MsgTransfer{ - SourcePort: "transfer", - SourceChannel: "myChanID", - Token: sdk.Coin{ - Denom: "ALX", - Amount: sdk.NewInt(1), - }, - Sender: addr1.String(), - Receiver: addr2.String(), - TimeoutTimestamp: 100, - TimeoutHeight: clienttypes.NewHeight(2, 1), - }, - }, - }, - "IBC close channel": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - IBC: &wasmvmtypes.IBCMsg{ - CloseChannel: &wasmvmtypes.CloseChannelMsg{ - ChannelID: "channel-1", - }, - }, - }, - output: []sdk.Msg{ - &channeltypes.MsgChannelCloseInit{ - PortId: "wasm." + addr1.String(), - ChannelId: "channel-1", - Signer: addr1.String(), - }, - }, - }, - "Gov vote: yes": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - Gov: &wasmvmtypes.GovMsg{ - Vote: &wasmvmtypes.VoteMsg{ProposalId: 1, Vote: wasmvmtypes.Yes}, - }, - }, - output: []sdk.Msg{ - &govtypes.MsgVote{ - ProposalId: 1, - Voter: addr1.String(), - Option: govtypes.OptionYes, - }, - }, - }, - "Gov vote: No": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - Gov: &wasmvmtypes.GovMsg{ - Vote: &wasmvmtypes.VoteMsg{ProposalId: 1, Vote: wasmvmtypes.No}, - }, - }, - output: []sdk.Msg{ - &govtypes.MsgVote{ - ProposalId: 1, - Voter: addr1.String(), - Option: govtypes.OptionNo, - }, - }, - }, - "Gov vote: Abstain": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - Gov: &wasmvmtypes.GovMsg{ - Vote: &wasmvmtypes.VoteMsg{ProposalId: 10, Vote: wasmvmtypes.Abstain}, - }, - }, - output: []sdk.Msg{ - &govtypes.MsgVote{ - ProposalId: 10, - Voter: addr1.String(), - Option: govtypes.OptionAbstain, - }, - }, - }, - "Gov vote: No with veto": { - sender: addr1, - srcContractIBCPort: "myIBCPort", - srcMsg: wasmvmtypes.CosmosMsg{ - Gov: &wasmvmtypes.GovMsg{ - Vote: &wasmvmtypes.VoteMsg{ProposalId: 1, Vote: wasmvmtypes.NoWithVeto}, - }, - }, - output: []sdk.Msg{ - &govtypes.MsgVote{ - ProposalId: 1, - Voter: addr1.String(), - Option: govtypes.OptionNoWithVeto, - }, - }, - }, "stargate encoded filtered (fswap)": { sender: addr1, srcMsg: wasmvmtypes.CosmosMsg{