Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CBA Setting for Marker Editing Functionality #735

Closed
Bob-Murphy opened this issue May 14, 2023 · 1 comment · Fixed by #736
Closed

Add CBA Setting for Marker Editing Functionality #735

Bob-Murphy opened this issue May 14, 2023 · 1 comment · Fixed by #736
Labels
enhancement Improves an existing feature
Milestone

Comments

@Bob-Murphy
Copy link

Is your feature request related to a problem?
Yes.
The ability to Support editing all area markers #676 has lead to the issue that when playing missions/mods like Antistasi, Vindicta, Liberation or else the markers within those missions, which in most cases are essential for the mission running, can be moved, edited and deleted as well.
Hence it can easily happen that people playing those missions/mods and using ZEN could by accident change/delete one or multiple and therefore break their game.

Solution you'd like:
Implement a CBA setting which either is disabled by default or at least can be disabled by code within the mod/mission itself.
This way the feature in itself stays available (certainly a good feature and no reason to remove it) but gives creators/players the option to disable it for "safety" reasons. It's better to be able to prevent mishaps in the first place.

Alternatives you've considered:
Unfortunately I don't have another easy to implement solution which would give the same functionality and keep the feature within ZEN.

Additional context:
If you want to replicate the usecase, subscribe to the Antstasi Mod (https://steamcommunity.com/sharedfiles/filedetails/?id=2867537125), launch it in local hosted with CBA and ZEN loaded and observe that you can edit/delete the markers from Antistasi itseld.

Thank you for your mod.

@Bob-Murphy Bob-Murphy added the feature Adds a new feature label May 14, 2023
@mharis001
Copy link
Member

We could add a setting to control which area markers can be edited. There also already exists a way to blacklist markers through code:

// List of marker names that are blacklisted from being edited through Zeus
// A marker is blacklisted if its name contains any of strings in this list
GVAR(blacklist) = [];

@mharis001 mharis001 added enhancement Improves an existing feature and removed feature Adds a new feature labels May 16, 2023
@mharis001 mharis001 added this to the 1.14.0 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants