You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
How it worked before Input filter specification not merged for Collection #78
Case 1 prefer_form_input_filter => true sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 0 sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 0
Case 2 prefer_form_input_filter => false sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 1 sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 0
How it works after Input filter specification not merged for Collection #78 (now)
Case 1 prefer_form_input_filter => true sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 0 sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 1
Case 2 prefer_form_input_filter => false sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 1 sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 1
How it should work (my guess, but other behavior will mislead developers)
Case 1 prefer_form_input_filter => true sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 0 sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 0
Case 2 prefer_form_input_filter => false sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 1 sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 1
As far as I remember, prefer_form_input_filter was introduced to prevent BC break, but right now we did the same for collections input filter (and this is also BC break).
The text was updated successfully, but these errors were encountered:
InputFilter merging is inconsistent after #78 (was buggy before). I'll explain it basing on example below:
How it worked before Input filter specification not merged for Collection #78
Case 1
prefer_form_input_filter => true
sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 0
sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 0
Case 2
prefer_form_input_filter => false
sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 1
sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 0
How it works after Input filter specification not merged for Collection #78 (now)
Case 1
prefer_form_input_filter => true
sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 0
sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 1
Case 2
prefer_form_input_filter => false
sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 1
sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 1
How it should work (my guess, but other behavior will mislead developers)
Case 1
prefer_form_input_filter => true
sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 0
sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 0
Case 2
prefer_form_input_filter => false
sizeof($fieldsetElementInputFilter->getValidatorChain()->getValidators()) === 1
sizeof($collectionElementInputFilter->getValidatorChain()->getValidators()) === 1
As far as I remember,
prefer_form_input_filter
was introduced to prevent BC break, but right now we did the same for collections input filter (and this is also BC break).The text was updated successfully, but these errors were encountered: