From 11901e23a1464abb131a1eafe669bd325d98e19e Mon Sep 17 00:00:00 2001 From: Vytautas Stankus Date: Wed, 6 Apr 2016 18:15:32 +0300 Subject: [PATCH] use default console exception template instead of empty string --- src/Service/ConsoleExceptionStrategyFactory.php | 5 +++-- test/Service/ConsoleExceptionStrategyFactoryTest.php | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Service/ConsoleExceptionStrategyFactory.php b/src/Service/ConsoleExceptionStrategyFactory.php index e5d2f9b..aa4a0c2 100644 --- a/src/Service/ConsoleExceptionStrategyFactory.php +++ b/src/Service/ConsoleExceptionStrategyFactory.php @@ -66,7 +66,8 @@ private function injectDisplayExceptions(ExceptionStrategy $strategy, array $con */ private function injectExceptionMessage(ExceptionStrategy $strategy, array $config) { - $message = isset($config['exception_message']) ? $config['exception_message'] : ''; - $strategy->setMessage($message); + if (isset($config['exception_message'])) { + $strategy->setMessage($config['exception_message']); + } } } diff --git a/test/Service/ConsoleExceptionStrategyFactoryTest.php b/test/Service/ConsoleExceptionStrategyFactoryTest.php index 69c69a6..2f53f8d 100644 --- a/test/Service/ConsoleExceptionStrategyFactoryTest.php +++ b/test/Service/ConsoleExceptionStrategyFactoryTest.php @@ -29,13 +29,14 @@ public function testEnablesDisplayExceptionsWithoutConfiguration() $this->assertTrue($strategy->displayExceptions()); } - public function testProvidesEmptyExceptionMessageWithoutConfiguration() + public function testProvidesDefaultExceptionMessageWithoutConfiguration() { $this->container->has('config')->willReturn(false); $strategy = $this->factory->__invoke($this->container->reveal(), ExceptionStrategy::class); $this->assertInstanceOf(ExceptionStrategy::class, $strategy); - $this->assertEquals('', $strategy->getMessage()); + $plainStrategy = new ExceptionStrategy(); + $this->assertEquals($plainStrategy->getMessage(), $strategy->getMessage()); } public function overrideDisplayExceptionsConfiguration()