This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
SessionManager creates instance of $requestedName #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Zend v3 FactoryInterface by considering the $requestedName parameter when creating a SessionManager instance. This allows applications to extend SessionManager by still using the default factory with all its logic.
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
SessionManager creates instance of $requestedName
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
weierophinney
added a commit
that referenced
this pull request
Jun 19, 2017
|
Thanks, @thomascube |
|
Merged to develop for release with 2.8.0. |
weierophinney
added a commit
to Slamdunk/zend-session
that referenced
this pull request
Jun 19, 2017
New expectation introduced in zendframework#73 to use modern exception expectation method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to extend the behaviour and functionality of the (default)
SessionManagerin an application, one still wants to use the default factory with all its logic reading config and setting up the manager.This isn't possible if the class instantiated by the factory is hard-coded. This PR wants to solve this by considering the
$requestedNameparameter when creating aSessionManagerinstance. With a simple alias one can now create extended session managers.