Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image tagging strategy and CI to display both Azure and Terraform CLI version #16

Closed
bgauduch opened this issue May 18, 2019 · 3 comments · Fixed by #63
Closed

Update image tagging strategy and CI to display both Azure and Terraform CLI version #16

bgauduch opened this issue May 18, 2019 · 3 comments · Fixed by #63
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Milestone
First release wit...

Comments

@bgauduch
Copy link
Contributor

bgauduch commented May 18, 2019 •
edited
Loading

Instead of using arbitrary tag numbers like 2.3, it might be better to implement a real tagging strategy to display toolling version like so:

r1.2-tf0.12.9-azcli2.0.74

with:

  • r= release tag version
  • tf = Terraform CLI version
  • azcli= Azure CLI version
@bgauduch bgauduch added the enhancement New feature or request label May 18, 2019
@bgauduch bgauduch changed the title Use Docker Hub Hooks to provide multiple version images for both Azure & Terraform CLI Provide multiple version images for both Azure & Terraform CLI Oct 3, 2019
@bgauduch bgauduch changed the title Provide multiple version images for both Azure & Terraform CLI Provide multiple version images via the CI for both Azure & Terraform CLI Oct 7, 2019
@pyaillet
Copy link
Contributor

pyaillet commented Oct 9, 2019

This one is related to #46 I think.

How should we specify the supported terraform and az versions ?

@bgauduch bgauduch added help wanted Extra attention is needed question Further information is requested labels Oct 9, 2019
@bgauduch
Copy link
Contributor Author

bgauduch commented Oct 9, 2019

I believe it should be some env vars with a list of desired version, set up before calling a build script looping on it and producing all the images. It should be parralelized though, and will impact the current CI structure.

The final implementation is not clear for the moment, so the subject is open for suggestions 😉

@bgauduch
Copy link
Contributor Author

bgauduch commented May 6, 2020

I will implement this using Github action strategy.
closing duplicated #46.

@bgauduch bgauduch mentioned this issue May 6, 2020
Closed
@bgauduch bgauduch changed the title Provide multiple version images via the CI for both Azure & Terraform CLI Update image tagging strategy and CI to display both Azure and Terraform CLI version May 6, 2020
@bgauduch bgauduch mentioned this issue May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
First release with proper CI, new tag...
Development

Successfully merging a pull request may close this issue.

Add GitHub action for image CI and multi-tag strategy zenika-open-source/terraform-azure-cli
2 participants
@bgauduch @pyaillet