-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/configurable service account for seldon predictor service #1725
Feature/configurable service account for seldon predictor service #1725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add the serviceAccountName
to the docs section where SeldonDeploymentConfig
is mentioned, you can find it here!
Otherwise looks good
…unt-for-seldon-predictor-service Added serviceAccountName to build step
* Cloud architecture incoming * Added scenarios * Added scenarios * Added scenarios * Added scenarios * Optimised images with calibre/image-actions * latest data * Optimised images with calibre/image-actions * Updated architecture diagrams * Optimised images with calibre/image-actions * Fix image references * Fixed diagram for scenario 2.a * Optimised images with calibre/image-actions * Added stefans comment * Apply suggestions from code review Co-authored-by: Stefan Nica <stefan@zenml.io> * Apply suggestions from code review Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com> * Added remaining review things --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stefan Nica <stefan@zenml.io> Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com> (cherry picked from commit e936996)
* Update cloud architecture scenarios * Optimised images with calibre/image-actions * Minor docs updates --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit b21054e)
…seldon-predictor-service
…t-for-seldon-predictor-service
…seldon-predictor-service
…seldon-predictor-service
…or-service' of https://github.com/Johnyz21/zenml into feature/configurable-service-account-for-seldon-predictor-service
…don-predictor-service
Feature/update seldon readme
Updated the docs 🙌 |
…seldon-predictor-service
…seldon-predictor-service
…or-service' of https://github.com/Johnyz21/zenml into feature/configurable-service-account-for-seldon-predictor-service
…seldon-predictor-service
…seldon-predictor-service
Describe changes
I've added the ability to deploy Seldon Core V1 Models with a custom service account
Pre-requisites
Please ensure you have done the following:
Types of changes