Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configurable service account for seldon predictor service #1725

Conversation

Johnyz21
Copy link
Contributor

@Johnyz21 Johnyz21 commented Jul 31, 2023

Describe changes

I've added the ability to deploy Seldon Core V1 Models with a custom service account

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@schustmi schustmi requested a review from safoinme August 7, 2023 07:27
@strickvl strickvl added the enhancement New feature or request label Aug 7, 2023
Copy link
Contributor

@safoinme safoinme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the serviceAccountName to the docs section where SeldonDeploymentConfig is mentioned, you can find it here!
Otherwise looks good

Johnyz21 and others added 9 commits August 15, 2023 10:53
…unt-for-seldon-predictor-service

Added serviceAccountName to build step
* Cloud architecture incoming

* Added scenarios

* Added scenarios

* Added scenarios

* Added scenarios

* Optimised images with calibre/image-actions

* latest data

* Optimised images with calibre/image-actions

* Updated architecture diagrams

* Optimised images with calibre/image-actions

* Fix image references

* Fixed diagram for scenario 2.a

* Optimised images with calibre/image-actions

* Added stefans comment

* Apply suggestions from code review

Co-authored-by: Stefan Nica <stefan@zenml.io>

* Apply suggestions from code review

Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>

* Added remaining review things

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Stefan Nica <stefan@zenml.io>
Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
(cherry picked from commit e936996)
* Update cloud architecture scenarios

* Optimised images with calibre/image-actions

* Minor docs updates

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit b21054e)
@Johnyz21
Copy link
Contributor Author

Johnyz21 commented Nov 2, 2023

Can you please add the serviceAccountName to the docs section where SeldonDeploymentConfig is mentioned, you can find it here! Otherwise looks good

Updated the docs 🙌

@safoinme safoinme merged commit 2b661b4 into zenml-io:develop Nov 18, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants