-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning when artifact store cannot be loaded #2011
Add warning when artifact store cannot be loaded #2011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misremembered this function when talking about it on discord. I thought this was some kind of utility function which takes as input a run_name
, step_name
and output_name
and then fetches/loads the artifact.
If this is really just loading a specific artifact then it seems like a user error to try loading it when the integrations aren't available. Maybe in that case my suggestion of having this boolean flag does not make much sense, and we should rather just go with the improved error message that you already implemented as part of this PR as well?
@schustmi the improved error message doesn't help with the fact that I might not want it to assume to use an artifact store other than the one in my current stack. (Agreed though that not having the right dependencies installed is just user error which we can make a bit nicer with a nicer error message). |
But isn't that your fault then, if you want artifacts only from a specific store, then you should handle that when fetching the |
@schustmi ok you're probably right. The confusion (when using it) came when getting an artifact via the |
Yes, the flag should maybe be on the |
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Added:
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes