Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make helm chart more robust to accidental secret deletions #2053

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Make helm chart more robust to accidental secret deletions #2053

merged 1 commit into from
Nov 16, 2023

Conversation

stefannica
Copy link
Contributor

Describe changes

Make helm chart more robust to accidental secret deletions

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Nov 16, 2023
wjayesh
wjayesh approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@wjayesh wjayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix!

@stefannica stefannica merged commit 842990d into develop Nov 16, 2023
8 of 20 checks passed
@stefannica stefannica deleted the feature/make-helm-chart-more-robust branch November 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjayesh wjayesh wjayesh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefannica @wjayesh