Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom disk size and type when using VertexAI Step Operator #2054

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

strickvl
Copy link
Contributor

Updated our step operator to allow for custom disk sizes when using VertexAI step operator.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added enhancement New feature or request internal To filter out internal PRs and issues labels Nov 16, 2023
Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but can we test it somehow? Or we don't do vertex tests atm?

@strickvl
Copy link
Contributor Author

strickvl commented Nov 16, 2023

@avishniakov we don't do any tests on deployed infrastructure, but I have tested it to ensure it works.

Copy link
Contributor

E2E template updates in examples/e2e have been pushed.

@strickvl strickvl merged commit 8321f80 into develop Nov 23, 2023
5 checks passed
@strickvl strickvl deleted the feature/OSS-2623-vertex-disk-space branch November 23, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants