Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user name from orchestrator run name #2067

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Nov 21, 2023

Describe changes

When generating a run name which we use to display in the orchestrator UI, we previously included the user name. For ZenML cloud tenants, that user name is the email of the user, which contains an @ which leads to failure when running with Airflow.
To fix it, we simply remove the user name and increase the random portion of the run name.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@schustmi schustmi changed the title Use user ID instead of user name for orchestrator run name Remove user name from orchestrator run name Nov 21, 2023
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is unique and works for all orchestrators then LGTM!

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Nov 21, 2023
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@schustmi schustmi merged commit 575e0bb into develop Nov 22, 2023
30 checks passed
@schustmi schustmi deleted the bugfix/orchestrator-run-name branch November 22, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants