Fix CI #2069
Merged
Fix CI #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schustmi
requested changes
Nov 22, 2023
| @@ -48,11 +48,16 @@ install_integrations() { | |||
| zenml integration export-requirements \ | |||
| --output-file integration-requirements.txt \ | |||
| $ignore_integrations_args | |||
|
|
|||
| # pin pyyaml>=6.0.1 | |||
| echo "" >> integration-requirements.txt | |||
There was a problem hiding this comment.
Why is this necessary at all, shouldn't this get installed with the langchain integration installation anyway?
There was a problem hiding this comment.
It already failed during the pip install before the langchain integration is even installed
There was a problem hiding this comment.
(Since some other integrations use pyyaml too)
There was a problem hiding this comment.
It seemed to me that if you don't explicitly pin PyYAML globally, pip tries to download older versions of it if only to figure out if it can be used. I don't really understand why though.
stefannica
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
Following #1696, I added even more PyYAML pins to prevent PyYAML 5 from getting installed at all.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes