Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NLP Template Example (#2051) #2070

Merged
merged 18 commits into from
Nov 29, 2023
Merged

Adding NLP Template Example (#2051) #2070

merged 18 commits into from
Nov 29, 2023

Conversation

fa9r
Copy link
Contributor

@fa9r fa9r commented Nov 22, 2023

Describe changes

I implemented/fixed _ to achieve _.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Nov 22, 2023
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please fix the typos so that the tests pass?

@safoinme safoinme merged commit 11ff266 into develop Nov 29, 2023
33 of 37 checks passed
@safoinme safoinme deleted the feature/adding-nlp-case branch November 29, 2023 13:58
safoinme pushed a commit that referenced this pull request Nov 29, 2023
* adding nlp case example and updating tests for templates

* format and lint

* fix naming

* Auto-update of E2E template

* change ref-zenml to main till releasing 0.48.0

* fix template name

* Auto-update of NLP template

* Revert "Revert "Adding NLP Template Example (#2051)""

This reverts commit 1a55e00.

* remove the nlp case, test adding it with actions

* add nlp case example

* docstring and renaming

* fix save model version

---------

Co-authored-by: Safoine El Khabich <34200873+safoinme@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
(cherry picked from commit 11ff266)
safoinme added a commit that referenced this pull request Nov 29, 2023
* adding nlp case example and updating tests for templates

* format and lint

* fix naming

* Auto-update of E2E template

* change ref-zenml to main till releasing 0.48.0

* fix template name

* Auto-update of NLP template

* Revert "Revert "Adding NLP Template Example (#2051)""

This reverts commit 1a55e00.

* remove the nlp case, test adding it with actions

* add nlp case example

* docstring and renaming

* fix save model version

---------

Co-authored-by: Safoine El Khabich <34200873+safoinme@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
(cherry picked from commit 11ff266)

Co-authored-by: Felix Altenberger <felix@zenml.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants