-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding NLP Template Example (#2051) #2070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/adding-nlp-case
This reverts commit 1a55e00.
github-actions
bot
added
internal
To filter out internal PRs and issues
enhancement
New feature or request
labels
Nov 22, 2023
safoinme
approved these changes
Nov 29, 2023
strickvl
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please fix the typos so that the tests pass?
safoinme
pushed a commit
that referenced
this pull request
Nov 29, 2023
* adding nlp case example and updating tests for templates * format and lint * fix naming * Auto-update of E2E template * change ref-zenml to main till releasing 0.48.0 * fix template name * Auto-update of NLP template * Revert "Revert "Adding NLP Template Example (#2051)"" This reverts commit 1a55e00. * remove the nlp case, test adding it with actions * add nlp case example * docstring and renaming * fix save model version --------- Co-authored-by: Safoine El Khabich <34200873+safoinme@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com> (cherry picked from commit 11ff266)
safoinme
added a commit
that referenced
this pull request
Nov 29, 2023
* adding nlp case example and updating tests for templates * format and lint * fix naming * Auto-update of E2E template * change ref-zenml to main till releasing 0.48.0 * fix template name * Auto-update of NLP template * Revert "Revert "Adding NLP Template Example (#2051)"" This reverts commit 1a55e00. * remove the nlp case, test adding it with actions * add nlp case example * docstring and renaming * fix save model version --------- Co-authored-by: Safoine El Khabich <34200873+safoinme@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com> (cherry picked from commit 11ff266) Co-authored-by: Felix Altenberger <felix@zenml.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes