-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take integrations tests out of unit tests folder #2100
Take integrations tests out of unit tests folder #2100
Conversation
@safoinme 100% we can split up the tests that way. IMO we should have:
We'll make those changes in coming weeks, I think, but this PR is a good start towards that. |
Previously the proportions (according to the above split) were: End-to-End tests: 20 And now with this PR the proportions have become: End-to-End tests: 20 In the end, I think you usually want to have quite a bit more unit tests than these integration tests, but in our case maybe it's a bit special given how much ZenML caters to these kinds of extra things being installed. |
If i may add, i think there is some integrations that can be questioned or in another word can be considered unit, should we create a different PR for that an put it to review? @strickvl |
@safoinme can you give an example? Also are you making sure that anything you're removing from unit tests might no longer need to be installed for unit test runners etc (so making any updates to the CI installation)? I'm not sure if that applies here. |
…github.com:zenml-io/zenml into feature/OSS-2625-split-unit-from-integration-tests
…github.com:zenml-io/zenml into feature/OSS-2625-split-unit-from-integration-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending tests passing ofc. Remaining pieces to this:
- handling caching (v important)
- monitoring the speed / load on our runners and how we can best allocate those resources
- Windows runners on the Azure cluster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @strickvl comments
os: [ubuntu-dind-runners] | ||
# Disabled temporarily while CI is overhauled | ||
python-version: ["3.8", "3.9", "3.10"] | ||
# python-version: ["3.8", "3.9", "3.10", "3.11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls remove commented out code
Describe changes
It's a bit confusing where to draw the line between integration and unit, if consider any interaction with the file system as integration that needs to be taken out but that seems a bit too much since most of these tests have very limited scope and one isolated so for that only one actual test that wasn't is the
zen_server
. I also would like to challenge the idea of keeping the zenml integrations tests folder under the unit instead of having it part of the integration, would it be possible to have a unit test workflow just with zenml not with all integrations installed?Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes